[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #286: Add an agent plugin to support tomcat10.x(#7420)

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #286:
URL: https://github.com/apache/skywalking-java/pull/286#discussion_r926285123


##########
apm-sniffer/apm-sdk-plugin/tomcat-7.x-8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/tomcat78x/define/TomcatInstrumentation.java:
##########
@@ -45,6 +45,11 @@ public class TomcatInstrumentation extends ClassInstanceMethodsEnhancePluginDefi
      */
     private static final String EXCEPTION_INTERCEPT_CLASS = "org.apache.skywalking.apm.plugin.tomcat78x.TomcatExceptionInterceptor";
 
+    @Override
+    protected String[] witnessClasses() {
+        return new String[]{"javax.servlet.http.HttpServletResponse"};

Review Comment:
   Does this only exist in Tomcat 10? This looks like a J2EE class. Why do you choose this as a witness class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org