You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Matt McGinty (JIRA)" <my...@incubator.apache.org> on 2005/04/21 20:05:23 UTC
[jira] Created: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
-------------------------------------------------------------------------------------------------------------------------------
Key: MYFACES-206
URL: http://issues.apache.org/jira/browse/MYFACES-206
Project: MyFaces
Type: Bug
Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
Reporter: Matt McGinty
Priority: Blocker
>From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
---
<attribute>
<name>target</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
<!-- HtmlOutputLink attributes -->
<attribute>
<name>target</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
---
That's the same name for 2 attributes... for the same tag.
That seems wrong to me.
What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
Which one would the JSP Engine be expected to use?
And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
<attribute>
<name>id</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
and also
<attribute>
<name>id</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
<type>java.lang.String</type>
<description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
They are slightly different.
Tomcat 5 does not appear to complain or report this, and things work fine there.
But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
Duplicated attributes in a TLD seems ambiguous to me.
>From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
other) about the case of a TLD using the same attribute name for the same tag more than once.
But common sense tells me it should not be done.
Does it make sense for a TLD to do this?
Doesn't MyFaces need to correct their TLD files in these cases?
If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
Other examples I've found so far in myfaces_ext.tld include:
1. the attribute named "onblur" for the tag named "commandNavigation"
2. the attribute named "onfocus" for the tag named "commandNavigation"
3. the attribute named "id" for the tag named "inputHtml"
4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
Thanks for your time,
Matt McGinty
Software Engineer
New Atlanta Communications, LLC
http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Created: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by Sean Schofield <se...@gmail.com>.
If there are duplicate attributes in the TLD that would seem to be a
mistake on our part. I will give a chance for the other committers to
weigh in on this before I fix it. Matt, can you supply a patch for
the fixes that you have already identified? That would help speed up
the fix since we are working on several issues at the moment.
On 4/21/05, Matt McGinty (JIRA) <my...@incubator.apache.org> wrote:
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Priority: Blocker
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
>
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
>
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
>
> <!-- HtmlOutputLink attributes -->
>
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
>
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
>
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
>
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
>
> and also
>
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
>
> They are slightly different.
>
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
>
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
>
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
>
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
>
> Other examples I've found so far in myfaces_ext.tld include:
>
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
>
> Thanks for your time,
>
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
[jira] Commented: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "Matt McGinty (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=comments#action_63439 ]
Matt McGinty commented on MYFACES-206:
--------------------------------------
Hey I went ahead and completed the mods. needed to get this working in SE.
There were just 2 other attributes in myfaces_ext.tld that were duplicated:
The attribute named "style" for the tag named "popup"
The attribute named "styleClass" for the same tag... "popup".
I just commented out the 2nd occurance of each of those 2 attributes, reloaded the app and now I seems to be working in SE.
I have a customer who was trying to use this app in SE 5.0, so I'll provide them with my modified versions of these 2 TLD's.
Take care.
Oh, wait.
The home.jsf page comes up fine, but I trying to run Sample 1 gives a blank page and I'm getting an error in ServletExec.log.
Hang on, let me look at this for a moment...
Matt
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Priority: Blocker
> Attachments: myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "Matt McGinty (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=all ]
Matt McGinty updated MYFACES-206:
---------------------------------
Attachment: myfaces_html.tld
myfaces_ext.tld
Sean, You requested that I provide any patch that I have.
I've attached the only 2 TLDs that I've touched.
All I did in them was to comment out some of the duplicated attributes that SE was complaining about.
As I recall, myfaces_html.tld only had 1 duplicated attribute and I commented that one out.
myfaces_ext.tld had more than 1, I commeted out 3 or 4 of them but other duplicates remain to be removed or commented out
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Priority: Blocker
> Attachments: myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=comments#action_63687 ]
sean schofield commented on MYFACES-206:
----------------------------------------
So what is the status on these TLD's. Should I commit them?
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Priority: Blocker
> Attachments: myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=comments#action_63429 ]
sean schofield commented on MYFACES-206:
----------------------------------------
If there are duplicate attributes in the TLD that would seem to be a
mistake on our part. I will give a chance for the other committers to
weigh in on this before I fix it. Matt, can you supply a patch for
the fixes that you have already identified? That would help speed up
the fix since we are working on several issues at the moment.
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Priority: Blocker
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=all ]
sean schofield updated MYFACES-206:
-----------------------------------
Priority: Major (was: Blocker)
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Attachments: myfaces_ext.tld, myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "Matt McGinty (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=comments#action_12318349 ]
Matt McGinty commented on MYFACES-206:
--------------------------------------
I believe there were just 2 problematic TLD's... the same 2 that I had submitted/attached before:
myfaces_ext.tld
and
myfaces_html.tld
I'm not comfortable/familiar enough with this project to "issue a patch".
Hopefully you can use what I sent to put the changes into the appropriate place.
All I did was to comment out duplicated tags in those 2 TLDs.
Thanks.
Matt
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Attachments: myfaces_ext.tld, myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=comments#action_63902 ]
sean schofield commented on MYFACES-206:
----------------------------------------
There is a problem with the TLD attachments provided. These are modified *after* the entities have been all resolved. We need to modify the TLDs in the incubator-myfaces/tlds directory. These TLD's are later modified by resolve_entities.xsl to produce the version of the TLD's that Matt modified. I suspect that man of the duplications are because the attribute appears in both the TLD and the entity. Its also possible that they appear in multiple entitities will which make it trickier to solve.
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Priority: Blocker
> Attachments: myfaces_ext.tld, myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=comments#action_12318327 ]
sean schofield commented on MYFACES-206:
----------------------------------------
Matt, I'd like to close this bug out. Can you issue a new patch or give us a list of the problematic TLD's?
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Attachments: myfaces_ext.tld, myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=all ]
sean schofield closed MYFACES-206:
----------------------------------
Fix Version: Nightly Build
Resolution: Fixed
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: 1.0.9 beta
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Fix For: Nightly Build
> Attachments: myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "Matt McGinty (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=all ]
Matt McGinty updated MYFACES-206:
---------------------------------
Attachment: myfaces_ext.tld
Here is the version of myfaces_ext.tld that has ALL duplicated attributes commented out.
Use it instead of the first myfaces_ext.tld that I sent.
Where we stand on this issue is that the 2 TLD's I've modified should be used instead of the ones that come with the example. This way SE doesn't complain about duplicated attributes in those 2 TLDs.
Yes, please commit them.
Matt McGinty
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Priority: Blocker
> Attachments: myfaces_ext.tld, myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-206) TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-206?page=all ]
sean schofield updated MYFACES-206:
-----------------------------------
Component: General
Description:
>From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
---
<attribute>
<name>target</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
<!-- HtmlOutputLink attributes -->
<attribute>
<name>target</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
---
That's the same name for 2 attributes... for the same tag.
That seems wrong to me.
What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
Which one would the JSP Engine be expected to use?
And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
<attribute>
<name>id</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
and also
<attribute>
<name>id</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
<type>java.lang.String</type>
<description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
They are slightly different.
Tomcat 5 does not appear to complain or report this, and things work fine there.
But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
Duplicated attributes in a TLD seems ambiguous to me.
>From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
other) about the case of a TLD using the same attribute name for the same tag more than once.
But common sense tells me it should not be done.
Does it make sense for a TLD to do this?
Doesn't MyFaces need to correct their TLD files in these cases?
If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
Other examples I've found so far in myfaces_ext.tld include:
1. the attribute named "onblur" for the tag named "commandNavigation"
2. the attribute named "onfocus" for the tag named "commandNavigation"
3. the attribute named "id" for the tag named "inputHtml"
4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
Thanks for your time,
Matt McGinty
Software Engineer
New Atlanta Communications, LLC
http://www.newatlanta.com
was:
>From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
---
<attribute>
<name>target</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
<!-- HtmlOutputLink attributes -->
<attribute>
<name>target</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
---
That's the same name for 2 attributes... for the same tag.
That seems wrong to me.
What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
Which one would the JSP Engine be expected to use?
And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
<attribute>
<name>id</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
</attribute>
and also
<attribute>
<name>id</name>
<required>false</required>
<rtexprvalue>false</rtexprvalue>
<type>java.lang.String</type>
<description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
They are slightly different.
Tomcat 5 does not appear to complain or report this, and things work fine there.
But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
Duplicated attributes in a TLD seems ambiguous to me.
>From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
other) about the case of a TLD using the same attribute name for the same tag more than once.
But common sense tells me it should not be done.
Does it make sense for a TLD to do this?
Doesn't MyFaces need to correct their TLD files in these cases?
If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
Other examples I've found so far in myfaces_ext.tld include:
1. the attribute named "onblur" for the tag named "commandNavigation"
2. the attribute named "onfocus" for the tag named "commandNavigation"
3. the attribute named "id" for the tag named "inputHtml"
4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
Thanks for your time,
Matt McGinty
Software Engineer
New Atlanta Communications, LLC
http://www.newatlanta.com
Version: 1.0.9 beta
> TLDs in myfaces-examples.war contain duplicated attributes for some tags which prevents the war from working in ServletExec 5.0
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-206
> URL: http://issues.apache.org/jira/browse/MYFACES-206
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: 1.0.9 beta
> Environment: Win XP Pro, JDK 1.5.0_01 using SE 5.0 AS running with it's built-in webserver
> Reporter: Matt McGinty
> Assignee: sean schofield
> Fix For: Nightly Build
> Attachments: myfaces_ext.tld, myfaces_html.tld
>
> From what I can tell, the myfaces-examples.war (from both myfaces-1.0.9rc3-app.tgz AND myfaces-1.0.8-examples.tgz)
> has TLD files (inside it's myfaces.jar file) that appear to be incorrect.
> For example, looking in the myfaces_html.tld file... looking in the <tag> named "outputLink", it contains:
> ---
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> <!-- HtmlOutputLink attributes -->
> <attribute>
> <name>target</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> ---
> That's the same name for 2 attributes... for the same tag.
> That seems wrong to me.
> What if that duplicated attribute name was using different values for the <required> or <rtexprvalue> nodes?
> Which one would the JSP Engine be expected to use?
> And looking in myfaces_ext.tld looking at the tag named "inputHtml". It see that it defines:
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> </attribute>
> and also
> <attribute>
> <name>id</name>
> <required>false</required>
> <rtexprvalue>false</rtexprvalue>
> <type>java.lang.String</type>
> <description>Every component may have an unique id. Automatically created if omitted.</description> </attribute>
> They are slightly different.
> Tomcat 5 does not appear to complain or report this, and things work fine there.
> But other Servlet/JSP Engines (not just SE) may perform validation on the TLD and complain about the duplicated attributes which may prevent the app from functioning.
> Duplicated attributes in a TLD seems ambiguous to me.
> From what I can tell, the JSP 2.0 specification does not say anything definitive (one way or the
> other) about the case of a TLD using the same attribute name for the same tag more than once.
> But common sense tells me it should not be done.
> Does it make sense for a TLD to do this?
> Doesn't MyFaces need to correct their TLD files in these cases?
> If I rig SE so that it doesn't check for duplicated attributes in a TLD, the app deploys and runs fine.
> But I don't think that SE should have to be altered in this way (unless someone has found information that I haven't... if so please share that with me).
> Otherwise, I think that the TLDs used in this MyFaces example need to be corrected.
> Other examples I've found so far in myfaces_ext.tld include:
> 1. the attribute named "onblur" for the tag named "commandNavigation"
> 2. the attribute named "onfocus" for the tag named "commandNavigation"
> 3. the attribute named "id" for the tag named "inputHtml"
> 4. the attribute named "style" for the tag named ... (Here is where I stopped debugging this).
> Thanks for your time,
> Matt McGinty
> Software Engineer
> New Atlanta Communications, LLC
> http://www.newatlanta.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira