You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/10/10 10:56:25 UTC
[GitHub] [cassandra] smiklosovic opened a new pull request, #1903: CASSANDRA-17955
smiklosovic opened a new pull request, #1903:
URL: https://github.com/apache/cassandra/pull/1903
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a diff in pull request #1903: CASSANDRA-17955
Posted by GitBox <gi...@apache.org>.
dcapwell commented on code in PR #1903:
URL: https://github.com/apache/cassandra/pull/1903#discussion_r1002167754
##########
src/java/org/apache/cassandra/service/ActiveRepairService.java:
##########
@@ -198,10 +198,10 @@ public static ThreadPoolExecutor repairCommandExecutor()
private final Gossiper gossiper;
private final Cache<Integer, Pair<ParentRepairStatus, List<String>>> repairStatusByCmd;
- private final DebuggableThreadPoolExecutor clearSnapshotExecutor = DebuggableThreadPoolExecutor.createWithMaximumPoolSize("RepairClearSnapshot",
Review Comment:
yes you are right, `JMXEnabledThreadPoolExecutor` exposes but this doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a diff in pull request #1903: CASSANDRA-17955
Posted by GitBox <gi...@apache.org>.
dcapwell commented on code in PR #1903:
URL: https://github.com/apache/cassandra/pull/1903#discussion_r991644746
##########
src/java/org/apache/cassandra/service/ActiveRepairService.java:
##########
@@ -198,10 +198,10 @@ public static ThreadPoolExecutor repairCommandExecutor()
private final Gossiper gossiper;
private final Cache<Integer, Pair<ParentRepairStatus, List<String>>> repairStatusByCmd;
- private final DebuggableThreadPoolExecutor clearSnapshotExecutor = DebuggableThreadPoolExecutor.createWithMaximumPoolSize("RepairClearSnapshot",
Review Comment:
given this is a `DebuggableThreadPoolExecutor` the name would have been exposed via JMX, so renaming the string could be a regression if we released that name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1903: CASSANDRA-17955
Posted by GitBox <gi...@apache.org>.
smiklosovic commented on code in PR #1903:
URL: https://github.com/apache/cassandra/pull/1903#discussion_r991913197
##########
src/java/org/apache/cassandra/service/ActiveRepairService.java:
##########
@@ -198,10 +198,10 @@ public static ThreadPoolExecutor repairCommandExecutor()
private final Gossiper gossiper;
private final Cache<Integer, Pair<ParentRepairStatus, List<String>>> repairStatusByCmd;
- private final DebuggableThreadPoolExecutor clearSnapshotExecutor = DebuggableThreadPoolExecutor.createWithMaximumPoolSize("RepairClearSnapshot",
Review Comment:
@dcapwell where are they exposed? Are not only `JMXEnabledThreadPoolExecutor`s exposed to a user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1903: CASSANDRA-17955
Posted by GitBox <gi...@apache.org>.
smiklosovic commented on code in PR #1903:
URL: https://github.com/apache/cassandra/pull/1903#discussion_r991169713
##########
src/java/org/apache/cassandra/service/ActiveRepairService.java:
##########
@@ -198,10 +198,10 @@ public static ThreadPoolExecutor repairCommandExecutor()
private final Gossiper gossiper;
private final Cache<Integer, Pair<ParentRepairStatus, List<String>>> repairStatusByCmd;
- private final DebuggableThreadPoolExecutor clearSnapshotExecutor = DebuggableThreadPoolExecutor.createWithMaximumPoolSize("RepairClearSnapshot",
Review Comment:
I renamed this executor as it is not only clearing snapshots anymore. Also I had to make it public to call it from outside, obviously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #1903: CASSANDRA-17955
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #1903: CASSANDRA-17955
URL: https://github.com/apache/cassandra/pull/1903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org