[GitHub] [airflow] ephraimbuddy commented on a change in pull request #21684: Add dependency to the running_deps

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #21684:
URL: https://github.com/apache/airflow/pull/21684#discussion_r810829508



##########
File path: airflow/ti_deps/deps/exec_date_after_start_date_dep.py
##########
@@ -28,15 +28,19 @@ class ExecDateAfterStartDateDep(BaseTIDep):
 
     @provide_session
     def _get_dep_statuses(self, ti, session, dep_context):
-        if ti.task.start_date and ti.execution_date < ti.task.start_date:
+        if ti.task.start_date and ti.get_dagrun(session=session).execution_date < ti.task.start_date:

Review comment:
       Any reason why we are changing this? I think the ti.execution_date will be available at this point. 
   

##########
File path: tests/models/test_dag.py
##########
@@ -2029,14 +2029,14 @@ def test_count_number_queries(self, tasks_count):
 
 
 class TestDagDecorator(unittest.TestCase):
+    DEFAULT_DATE = timezone.datetime(2016, 1, 1)
     DEFAULT_ARGS = {
         "owner": "test",
         "depends_on_past": True,
-        "start_date": timezone.utcnow(),
+        "start_date": DEFAULT_DATE,

Review comment:
       Unrelated?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org