You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 23:33:04 UTC

[GitHub] [beam] damccorm opened a new issue, #21451: Drop the clock abastraction and just use time.time for time measurements

damccorm opened a new issue, #21451:
URL: https://github.com/apache/beam/issues/21451

   Right now the TFX-BSL Runinference library uses an abstract clock class to get microsecond precision, but time.time should give an adequate precision.
   
    
   
   Investigate removing the clock abstraction and just using time.time.
   
    
   
   Alternatively, comment why the abstraction is useful.
   
   Imported from Jira [BEAM-14255](https://issues.apache.org/jira/browse/BEAM-14255). Original Jira may contain additional context.
   Reported by: Ryan.Thompson.
   Subtask of issue #21435


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] ryanthompson591 commented on issue #21451: Drop the clock abstraction and just use time.time for time measurements

Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on issue #21451:
URL: https://github.com/apache/beam/issues/21451#issuecomment-1273864790

   .close-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on issue #21451: Drop the clock abstraction and just use time.time for time measurements

Posted by GitBox <gi...@apache.org>.
damccorm commented on issue #21451:
URL: https://github.com/apache/beam/issues/21451#issuecomment-1238568387

   @ryanthompson591 now that #21442 is done, can we close this one too? Was this referring to this clock usage https://github.com/tensorflow/tfx-bsl/blob/396812f4ac8361db9396ec9780abe098d88869f0/tfx_bsl/beam/run_inference_base.py#L166


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] closed issue #21451: Drop the clock abstraction and just use time.time for time measurements

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #21451: Drop the clock abstraction and just use time.time for time measurements
URL: https://github.com/apache/beam/issues/21451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on issue #21451: Drop the clock abastraction and just use time.time for time measurements

Posted by GitBox <gi...@apache.org>.
damccorm commented on issue #21451:
URL: https://github.com/apache/beam/issues/21451#issuecomment-1146702791

   Unable to assign user @ryanthompson591. If able, self-assign, otherwise tag @damccorm so that he can assign you. Because of GitHub's spam prevention system, your activity is required to enable assignment in this repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org