[GitHub] jena issue #237: JENA-1313: compare using a Collator when both literals are ...

[osma <gi...@git.apache.org>]

Github user osma commented on the issue:

    https://github.com/apache/jena/pull/237
  
    @kinow I think this looks promising! I don't have much comments about the implementation code, but just being able to use `ORDER BY arq:collation("fi", ?label)` seems that it would do a good job of solving my original problem. I do like the way you have smuggled in the collation information so that it's accessible to the `NodeValue.compare` function and it can thus rely on `Collator.compare`, which should be pretty fast. Maybe there's a more elegant way of doing that smuggling, but at least it seems to get the job done based on your example results.
    
    Did you by any chance test this with the [performance test case](https://issues.apache.org/jira/browse/JENA-1313?focusedCommentId=15963023&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15963023) that I wrote up earlier? I'd like to know how it compares to a plain ORDER BY in terms of performance. I can test that myself too when I have a suitable slot of time, but that might take a while since many deadlines are coming up in the next few days...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---