You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/16 06:13:27 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #35863: [SPARK-38558][SQL] Remove unnecessary casts between IntegerType and IntDecimal
cloud-fan commented on a change in pull request #35863:
URL: https://github.com/apache/spark/pull/35863#discussion_r827658827
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -825,7 +825,7 @@ case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindow
zero,
zero,
zero,
- (n.cast(DecimalType.IntDecimal) / buckets.cast(DecimalType.IntDecimal)).cast(IntegerType),
+ (n div buckets).cast(IntegerType),
Review comment:
yea, it's a new fix to replace https://github.com/apache/spark/commit/ec8a1a8e8869b000a8001126ca013b753acddf6a
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -825,7 +825,7 @@ case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindow
zero,
zero,
zero,
- (n.cast(DecimalType.IntDecimal) / buckets.cast(DecimalType.IntDecimal)).cast(IntegerType),
+ (n div buckets).cast(IntegerType),
Review comment:
yea, it's a better fix to replace https://github.com/apache/spark/commit/ec8a1a8e8869b000a8001126ca013b753acddf6a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org