You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "MiniSho (via GitHub)" <gi...@apache.org> on 2023/02/23 09:19:56 UTC
[GitHub] [iotdb] MiniSho opened a new pull request, #9131: [IOTDB-5575] build SDK for Pipe framework
MiniSho opened a new pull request, #9131:
URL: https://github.com/apache/iotdb/pull/9131
we support Pipe SDK for users to custom implementations of PipeProcessor and PipeConnector plugins, in order to realize synchornization function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #9131: [IOTDB-5575] Pipe SDK: PipeProcessor & PipeConnector
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #9131:
URL: https://github.com/apache/iotdb/pull/9131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a diff in pull request #9131: [IOTDB-5575] build SDK for Pipe framework
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu commented on code in PR #9131:
URL: https://github.com/apache/iotdb/pull/9131#discussion_r1118046112
##########
pipe-api/src/main/java/org/apache/iotdb/pipe/api/PipeConnector.java:
##########
@@ -19,104 +19,117 @@
package org.apache.iotdb.pipe.api;
-import org.apache.iotdb.pipe.api.customizer.config.ConnectorRuntimeConfiguration;
-import org.apache.iotdb.pipe.api.customizer.paramater.PipeParameters;
-import org.apache.iotdb.pipe.api.customizer.paramater.PipeValidator;
-import org.apache.iotdb.pipe.api.event.DeletionEvent;
-import org.apache.iotdb.pipe.api.event.TabletInsertionEvent;
-import org.apache.iotdb.pipe.api.event.TsFileInsertionEvent;
+import org.apache.iotdb.pipe.api.customizer.connector.PipeConnectorRuntimeConfiguration;
+import org.apache.iotdb.pipe.api.customizer.PipeParameters;
+import org.apache.iotdb.pipe.api.customizer.PipeParameterValidator;
+import org.apache.iotdb.pipe.api.event.deletion.DeletionEvent;
+import org.apache.iotdb.pipe.api.event.insertion.TabletInsertionEvent;
+import org.apache.iotdb.pipe.api.event.insertion.TsFileInsertionEvent;
/**
* PipeConnector
*
- * <p>PipeConnector as the network layer, supports access to multiple transport protocols such as
- * ThriftRPC, HTTP, TCP, etc. for transferring data.
+ * <p>PipeConnector is responsible for sending events to sinks.
+ *
+ * <p>Various network protocols can be supported by implementing different PipeConnector classes.
*
* <p>The lifecycle of a PipeConnector is as follows:
*
* <ul>
- * <li>Before the collaboration task starts, the KV pair of `WITH CONNECTOR` clause in SQL is
- * parsed and the validate method {@link PipeConnector#validate(PipeValidator)}is called to
- * validate the parameters.
- * <li>When the collaboration task starts, load and initialize the PipeConnector instance, and
- * then call the beforeStart method {@link PipeConnector#beforeStart(PipeParameters,
- * ConnectorRuntimeConfiguration)}
- * <li>while the collaboration task is in progress
+ * <li>When a collaboration task is created, the KV pairs of `WITH CONNECTOR` clause in SQL are
+ * parsed and the validation method {@link PipeConnector#validate(PipeParameterValidator)}
+ * will be called to validate the parameters.
+ * <li>Before the collaboration task starts, the method {@link
+ * PipeConnector#customize(PipeParameters, PipeConnectorRuntimeConfiguration)} will be called
+ * to config the runtime behavior of the PipeConnector and the method {@link
+ * PipeConnector#handshake()} will be called to create a connection with sink.
+ * <li>While the collaboration task is in progress:
* <ul>
- * <li>PipeConnector calls the handshake method to establish connections between servers
- * <li>PipeConnector calls the transfer method to transfer data
- * <li>PipeConnector provides heartbeat detection method
+ * <li>PipeCollector captures the events and wraps them into three types of Event instances.
+ * <li>PipeProcessor processes the event them pass them to the PipeConnector.
Review Comment:
typos...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org