You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/05/14 18:35:26 UTC

[PR] Fix #12052: Tokenize arithmetic operators as delimiters in ConditionParser [maven]

gnodet opened a new pull request, #12053:
URL: https://github.com/apache/maven/pull/12053

   ## Summary
   
   - Add `-`, `*`, `/` to the delimiter character list in `ConditionParser.tokenize()` so arithmetic expressions without spaces (e.g., `5-3`, `6*4`, `9/3`) are correctly tokenized
   - This is safe because quoted strings and property references (`${my-property}`) are handled before the delimiter check, and `parseUnary()` already handles unary `-`
   
   Fixes #12052
   Related: #11882, #12038
   
   ## Test plan
   
   - [x] Added `testArithmeticWithoutSpaces` covering all operators without spaces, operator precedence, and unary negation
   - [x] All 27 `ConditionParserTest` tests pass
   
   _Claude Code on behalf of Guillaume Nodet_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #12052: Tokenize arithmetic operators as delimiters in ConditionParser [maven]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #12053:
URL: https://github.com/apache/maven/pull/12053#issuecomment-4721169660

   @gnodet Please assign appropriate label to PR according to the type of change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix #12052: Tokenize arithmetic operators as delimiters in ConditionParser [maven]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.

gnodet merged PR #12053:
URL: https://github.com/apache/maven/pull/12053


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org