You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/01 16:24:13 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
dongjoon-hyun opened a new pull request #29923:
URL: https://github.com/apache/spark/pull/29923
### What changes were proposed in this pull request?
This PR aims to upgrade Apache Hive `hive-storage-api` library from 2.7.1 to 2.7.2.
### Why are the changes needed?
2.7.2 has the following extension and can be used when users uses a provided orc dependency.
[HIVE-22959](https://github.com/apache/hive/commit/dade9919d904f8a4bff12a9130c150301a4713ed#diff-ccfc9dd7584117f531322cda3a29f3c3) : Extend storage-api to expose FilterContext
[HIVE-23215](https://github.com/apache/hive/commit/361925d2f3675bb9c6566b615a4b53faee335385#diff-ccfc9dd7584117f531322cda3a29f3c3) : Make FilterContext and MutableFilterContext interfaces
### Does this PR introduce _any_ user-facing change?
Yes. This is a dependency change.
### How was this patch tested?
Pass the existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29923:
URL: https://github.com/apache/spark/pull/29923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702296225
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33924/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702256028
**[Test build #129309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129309/testReport)** for PR 29923 at commit [`9239285`](https://github.com/apache/spark/commit/92392857ae873d9d278ddabd9884907c14630ed6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-704062582
late LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702356220
Merged to master for Apache Spark 3.1.0 on December 2020.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702256028
**[Test build #129309 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129309/testReport)** for PR 29923 at commit [`9239285`](https://github.com/apache/spark/commit/92392857ae873d9d278ddabd9884907c14630ed6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702344724
**[Test build #129309 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129309/testReport)** for PR 29923 at commit [`9239285`](https://github.com/apache/spark/commit/92392857ae873d9d278ddabd9884907c14630ed6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702374186
Thanks for the heads up @dongjoon-hyun cc @cloud-fan who committed the most recent change to this suite as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702342093
Seems fine as a minor dependency update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702296253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702345161
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129309/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702345153
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702296253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702285756
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33924/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702320819
Could you review this please, @srowen ?
This is a helpful and safe patch when we are going to use Apache ORC 1.6.x which requires additional `FilterContext` from `hive-storage`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702345153
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29923: [SPARK-33047][BUILD] Upgrade hive-storage-api to 2.7.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29923:
URL: https://github.com/apache/spark/pull/29923#issuecomment-702356100
Thank you, @srowen . The Jenkins failure is irrelevant to this and GitHub Action passed.
```
org.apache.spark.storage.BlockManagerDecommissionIntegrationSuite.verify that shuffle blocks are migrated
```
cc @holdenk for the decommission integration suite flakiness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org