You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dan Hecht (Code Review)" <ge...@cloudera.org> on 2018/06/14 20:07:33 UTC
[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"
Dan Hecht has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10717
Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"
......................................................................
IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"
In this case, the query is failing. It happens to use the cancellation
path to cleanup, but from a user's perspective this is a query failure
not a cancellation. Reword the message to reflect that.
Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/10717/1
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 )
Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"
......................................................................
Patch Set 1: Code-Review+2
I agree with your reasoning
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:29:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 )
Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:35:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 )
Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Carry +2
http://gerrit.cloudera.org:8080/#/c/10717/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10717/1//COMMIT_MSG@7
PS1, Line 7: sa
> delete
Done
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:35:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10717 )
Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
......................................................................
IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
In this case, the query is failing. It happens to use the cancellation
path to cleanup, but from a user's perspective this is a query failure
not a cancellation. Reword the message to reflect that.
Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Reviewed-on: http://gerrit.cloudera.org:8080/10717
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 )
Change subject: IMPALA-6942: Reword error message to be say "Failed" rather than "Cancelled"
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10717/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10717/1//COMMIT_MSG@7
PS1, Line 7: be
delete
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:22:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 )
Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jun 2018 00:00:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10717
to look at the new patch set (#2).
Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
......................................................................
IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
In this case, the query is failing. It happens to use the cancellation
path to cleanup, but from a user's perspective this is a query failure
not a cancellation. Reword the message to reflect that.
Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/10717/2
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10717 )
Change subject: IMPALA-6942: Reword error message to say "Failed" rather than "Cancelled"
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2674/
--
To view, visit http://gerrit.cloudera.org:8080/10717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d8e755aef196e5c25205094af9c8486eb899344
Gerrit-Change-Number: 10717
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:35:27 +0000
Gerrit-HasComments: No