Re: [VOTE] KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

[Mickael Maison <mi...@gmail.com>]

Hi,

Quick update:
To handle reverting to the old behaviour with older brokers, I've
introduced a new exception, NoBatchedFindCoordinatorsException.
I've updated the KIP accordingly. For more details, see the discussion
in the pull request: https://github.com/apache/kafka/pull/10743

Thanks

On Tue, May 25, 2021 at 11:18 PM Sanjana Kaundinya <sk...@gmail.com> wrote:
>
> Hi Mickael,
> Just took a look at your draft PR, seems like your implementation is looking to change the way we call all consumer group APIs to leverage the new AdminApiHandler introduced by Jason as part of KIP-664. It also seems like someone already got started to rewrite the ListOffsets API using this new infrastructure with this PR: https://github.com/apache/kafka/pull/10467/files :). In any case this is very helpful and certainly changes my plans on how I intended to implement the KIP. I can volunteer to help review your PR once you’re done with it, since it will give me a good idea for my PR. I was also hoping to get KIP-709 into 3.0 before the code freeze, but given that we are now rewriting ListOffsets API, I think I’d better wait until you get your KIP in. Are you planning on getting KIP-699 into 3.0?
> Cheers,
> Sanjana
> On May 23, 2021, 11:35 PM -0700, Sanjana Kaundinya <sk...@gmail.com>, wrote:
> > Hi Mickael,
> > Thank you for your response! Will take a look at the draft PR later this week.
> > Cheers,
> > Sanjana
> > On May 21, 2021, 10:26 AM -0700, Mickael Maison <mi...@gmail.com>, wrote:
> > > Hi Sanjana,
> > >
> > > Again I'm sorry for the delay.
> > > I've opened a draft PR which hopefully will let you make progress on
> > > KIP-709. Let me know if you have any questions.
> > >
> > > Thanks
> > >
> > > On Thu, May 20, 2021 at 10:10 PM Sanjana Kaundinya <sk...@gmail.com> wrote:
> > > >
> > > > Hi Mickael,
> > > >
> > > > Apologies for pinging on this again, but just wondering if you got a chance to make any progress on this? Would love to take a look and help with the reviews if you have.
> > > >
> > > > Thanks,
> > > > Sanjana
> > > > On May 7, 2021, 3:33 AM -0700, Mickael Maison <mi...@gmail.com>, wrote:
> > > > > Hi Sanjana,
> > > > >
> > > > > Sorry for the late reply.
> > > > > I hope to have a draft PR next week.
> > > > >
> > > > > Thanks
> > > > >
> > > > > On Tue, May 4, 2021 at 11:11 PM Sanjana Kaundinya <sk...@gmail.com> wrote:
> > > > > >
> > > > > > Hi Mickael,
> > > > > >
> > > > > > Just wanted to ping the thread to inquire if you’ve made any progress on the implementation. I was planning on doing the implementation for KIP-709 and seeing how KIP-699 is something that’s tightly coupled and related to KIP-709 I thought I’d ask what the status of this KIP was.
> > > > > >
> > > > > > Thanks,
> > > > > > Sanjana
> > > > > > On Apr 13, 2021, 8:44 AM -0700, Rajini Sivaram <ra...@gmail.com>, wrote:
> > > > > > > Thanks Mickael!
> > > > > > >
> > > > > > > Regards,
> > > > > > >
> > > > > > > Rajini
> > > > > > >
> > > > > > > On Tue, Apr 13, 2021 at 4:40 PM Mickael Maison <mi...@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Thanks Rajini!
> > > > > > > > Yes it would be good to get it into 3.0. I've got some of it
> > > > > > > > implemented already, I'll try to get a PR out in the next couple of
> > > > > > > > weeks.
> > > > > > > >
> > > > > > > > I'm closing this vote. This KIP has been accepted with 3 +1 binding
> > > > > > > > votes from David, Tom and Rajini.
> > > > > > > >
> > > > > > > > On Tue, Apr 13, 2021 at 1:49 PM Rajini Sivaram <ra...@gmail.com>
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Hi Mickael,
> > > > > > > > >
> > > > > > > > > +1 (binding)
> > > > > > > > >
> > > > > > > > > Thanks for the KIP!. Looks like this KIP has sufficient votes. It will be
> > > > > > > > > good to get this into 3.0 along with KIP-709. Will you have time to work
> > > > > > > > on
> > > > > > > > > this? Please let us know if we can help with the implementation or
> > > > > > > > reviews.
> > > > > > > > >
> > > > > > > > > Thank you,
> > > > > > > > >
> > > > > > > > > Rajini
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Thu, Mar 18, 2021 at 4:00 PM Tom Bentley <tb...@redhat.com> wrote:
> > > > > > > > >
> > > > > > > > > > Hi Mickael,
> > > > > > > > > >
> > > > > > > > > > I'd like to re-cast my vote as +1 (binding) now I'm a committer.
> > > > > > > > > >
> > > > > > > > > > Thanks again,
> > > > > > > > > >
> > > > > > > > > > Tom
> > > > > > > > > >
> > > > > > > > > > On Tue, Mar 2, 2021 at 9:46 AM David Jacot <dj...@confluent.io>
> > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Thanks for the KIP, Mickael. +1 (binding)
> > > > > > > > > > >
> > > > > > > > > > > On Mon, Mar 1, 2021 at 11:53 AM Tom Bentley <tb...@redhat.com>
> > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > > +1 (non-binding), thanks Mickael.
> > > > > > > > > > > >
> > > > > > > > > > > > On Thu, Feb 25, 2021 at 6:32 PM Mickael Maison <
> > > > > > > > mimaison@apache.org>
> > > > > > > > > > > > wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > > Hi,
> > > > > > > > > > > > >
> > > > > > > > > > > > > I'd like to start a vote on KIP-699 to support resolving multiple
> > > > > > > > > > > > > coordinators at a time:
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-699%3A+Update+FindCoordinator+to+resolve+multiple+Coordinators+at+a+time
> > > > > > > > > > > > >
> > > > > > > > > > > > > Thanks
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > >