You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/01/13 21:36:00 UTC
Re: Review Request 64073: Fixed ignored Socket::accept discard when
using LibeventSSLSocketImpl.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64073/#review195393
-----------------------------------------------------------
I posted support for discarding Queue::get here:
https://reviews.apache.org/r/65150/
- Benjamin Mahler
On Nov. 26, 2017, 10:28 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64073/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2017, 10:28 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Avinash sridharan, and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently there is no way to discard `LibeventSSLSocketImpl::accept()` because `Queue::get()` isn't discardable. This patch uses an `await()` so that we can discard.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/libevent_ssl_socket.cpp 1c95ebabfefd07aaeb053b965ab8e4550dfccaef
>
>
> Diff: https://reviews.apache.org/r/64073/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>