You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/22 09:26:25 UTC

[GitHub] [flink] zentol opened a new pull request #13745: [FLINK-19767] Add AbstractSlotPoolFactory

zentol opened a new pull request #13745:
URL: https://github.com/apache/flink/pull/13745


   Add an abstract slot pool factory class to reduce code duplication when we introduce the new slot pool implementation in FLINK-19314.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13745: [FLINK-19767] Add AbstractSlotPoolFactory

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13745:
URL: https://github.com/apache/flink/pull/13745#issuecomment-714370772


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c6f0ef39c65468a7f613e31bac530b148d36a9d4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8095",
       "triggerID" : "c6f0ef39c65468a7f613e31bac530b148d36a9d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6f0ef39c65468a7f613e31bac530b148d36a9d4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8095) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13745: [FLINK-19767] Add AbstractSlotPoolFactory

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13745:
URL: https://github.com/apache/flink/pull/13745#issuecomment-714370772


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c6f0ef39c65468a7f613e31bac530b148d36a9d4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c6f0ef39c65468a7f613e31bac530b148d36a9d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6f0ef39c65468a7f613e31bac530b148d36a9d4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13745: [FLINK-19767] Add AbstractSlotPoolFactory

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13745:
URL: https://github.com/apache/flink/pull/13745#issuecomment-714362820

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit c6f0ef39c65468a7f613e31bac530b148d36a9d4 (Thu Oct 22 09:30:04 UTC 2020)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13745: [FLINK-19767] Add AbstractSlotPoolFactory

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13745:
URL: https://github.com/apache/flink/pull/13745#issuecomment-714370772


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c6f0ef39c65468a7f613e31bac530b148d36a9d4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8095",
       "triggerID" : "c6f0ef39c65468a7f613e31bac530b148d36a9d4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c6f0ef39c65468a7f613e31bac530b148d36a9d4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8095) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #13745: [FLINK-19767] Add AbstractSlotPoolFactory

Posted by GitBox <gi...@apache.org>.

zentol merged pull request #13745:
URL: https://github.com/apache/flink/pull/13745


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org