You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by "moresandeep (via GitHub)" <gi...@apache.org> on 2023/04/27 10:57:42 UTC

[GitHub] [knox] moresandeep commented on pull request #752: KNOX-2904 - Mark the endpoint as failed when we failover AND request is non-idempotent

moresandeep commented on PR #752:
URL: https://github.com/apache/knox/pull/752#issuecomment-1525475990

   > Hey @moresandeep !
   > 
   > Please forgive me for my dummy question(s), but there is something I'd like to clarify: in the current `failoverRequest` method, there are other actions in terms of URL-management such as `setupUrlHashLookup` and `activeURL.set(outboundRequest.getURI().toString())`. Aren't they required along with the new `markEndpointFailed`?
   
   Thank you for checking @smolnar82! I was debating whether to include them since we did not actually failover. But, reading your comments and the code again, we should be including it! I will update it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org