You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/10 11:46:31 UTC

[GitHub] whanice commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer side in RpcContext

whanice commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer side in RpcContext
URL: https://github.com/apache/incubator-dubbo/pull/1444#issuecomment-380070078
 
 
   the isProviderSide and isConsumerSide seem not use in dubbo framework. just a api for user.
   and the origin implementation is almost right.
   but when we set DUBBO_IP_TO_REGISTRY use hostname not ip , the check  is wrong. 
   and maybe  lookup dns to resolve hostname in implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services