You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/09/26 09:47:49 UTC
[GitHub] [echarts-doc] kongmoumou opened a new pull request #198: docs: add size option for dataZoom-slider
kongmoumou opened a new pull request #198:
URL: https://github.com/apache/echarts-doc/pull/198
According to source code, we could set size of dataZoom-slider.
https://github.com/apache/echarts/blob/4a8a7f58e772586eebfbb080d2d14f5ded5478c0/src/component/dataZoom/SliderZoomView.ts#L245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] kongmoumou commented on a change in pull request #198: docs: add size option for dataZoom-slider
Posted by GitBox <gi...@apache.org>.
kongmoumou commented on a change in pull request #198:
URL: https://github.com/apache/echarts-doc/pull/198#discussion_r810752238
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Width of dataZoom-slider component. Default to 30 when vertical, adaptive when horizontal.
Review comment:
Hi @Ovilia , is there any other problem? 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] pissang merged pull request #198: docs: add size option for dataZoom-slider
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #198:
URL: https://github.com/apache/echarts-doc/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] kongmoumou commented on a change in pull request #198: docs: add size option for dataZoom-slider
Posted by GitBox <gi...@apache.org>.
kongmoumou commented on a change in pull request #198:
URL: https://github.com/apache/echarts-doc/pull/198#discussion_r717244521
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Width of dataZoom-slider component. Default to 30 when vertical, adaptive when horizontal.
Review comment:
I saw the source code use `DEFAULT_FILLER_SIZE` and its value is 30 😂
https://github.com/apache/echarts/blob/4a8a7f58e772586eebfbb080d2d14f5ded5478c0/src/component/dataZoom/SliderZoomView.ts#L231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] Ovilia commented on a change in pull request #198: docs: add size option for dataZoom-slider
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #198:
URL: https://github.com/apache/echarts-doc/pull/198#discussion_r717222911
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Width of dataZoom-slider component. Default to 30 when vertical, adaptive when horizontal.
+
+## height(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Height of dataZoom-slider component. Default to 30 when horizontal, adaptive when vertical.
+
{{ use: partial-rect-layout(
componentName = 'dataZoom-slider'
) }}
Review comment:
Should be added after this block so that `width` and `height` should be displayed along with `left` and `right` and so on.
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Width of dataZoom-slider component. Default to 30 when vertical, adaptive when horizontal.
Review comment:
Where is the source code of `30`? It seems the default value is `'ph'` where the layout is calculated automatically. You should also mention what happens when all `left`, `right` and `width` are defined, which one is overriden.
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
Review comment:
Don't use 30 here since it's not the same with horizontal and vertical layout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] kongmoumou commented on a change in pull request #198: docs: add size option for dataZoom-slider
Posted by GitBox <gi...@apache.org>.
kongmoumou commented on a change in pull request #198:
URL: https://github.com/apache/echarts-doc/pull/198#discussion_r717244521
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Width of dataZoom-slider component. Default to 30 when vertical, adaptive when horizontal.
Review comment:
I saw the source code use `DEFAULT_FILLER_SIZE` and its value is 30 😂
https://github.com/apache/echarts/blob/4a8a7f58e772586eebfbb080d2d14f5ded5478c0/src/component/dataZoom/SliderZoomView.ts#L231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] Ovilia commented on a change in pull request #198: docs: add size option for dataZoom-slider
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #198:
URL: https://github.com/apache/echarts-doc/pull/198#discussion_r717222911
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Width of dataZoom-slider component. Default to 30 when vertical, adaptive when horizontal.
+
+## height(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Height of dataZoom-slider component. Default to 30 when horizontal, adaptive when vertical.
+
{{ use: partial-rect-layout(
componentName = 'dataZoom-slider'
) }}
Review comment:
Should be added after this block so that `width` and `height` should be displayed along with `left` and `right` and so on.
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
+
+<ExampleUIControlNumber default="30"/>
+
+Width of dataZoom-slider component. Default to 30 when vertical, adaptive when horizontal.
Review comment:
Where is the source code of `30`? It seems the default value is `'ph'` where the layout is calculated automatically. You should also mention what happens when all `left`, `right` and `width` are defined, which one is overriden.
##########
File path: en/option/component/data-zoom-slider.md
##########
@@ -213,6 +213,18 @@ Whether to update view while dragging. If it is set as `false`, the view will be
dataZoomName = 'dataZoom-slider'
) }}
+## width(string|number) = 30
Review comment:
Don't use 30 here since it's not the same with horizontal and vertical layout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org