[GitHub] [spark] cxzl25 commented on a diff in pull request #36787: [SPARK-39387][FOLLOWUP][TESTS] Add a test case for HIVE-25190

[GitBox <gi...@apache.org>]

cxzl25 commented on code in PR #36787:
URL: https://github.com/apache/spark/pull/36787#discussion_r891950939


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala:
##########
@@ -832,6 +832,18 @@ abstract class OrcQuerySuite extends OrcQueryTest with SharedSparkSession {
       }
     }
   }
+
+  test("SPARK-39387: Upgrade hive-storage-api to 2.7.3") {

Review Comment:
   > In addition, we can make the test pass with hive-storage-api 2.8.1 too.
   I also tried to upgrade to 2.8.1 yesterday, did a test, and found that some tests of the `OrcFilterSuite` were broken.
   
   Because [HIVE-24458](https://issues.apache.org/jira/browse/HIVE-24458) modifies the output of the `SearchArgument#toString` method, which causes some test comparisons to fail.
   
   Now there are two ways to solve it,
   1 is to modify the expect value of the suite.
   2 is to use `SearchArgumentImpl#toOldString` provided by HIVE-24458.
   
   I have now tried the second.
   
   https://github.com/cxzl25/spark/commit/0adfdf60762faef2450f2f3c54c68f1109c5092e
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org