You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 12:51:37 UTC

[GitHub] [arrow] nevi-me commented on pull request #9271: ARROW-11300: [Rust][DataFusion] Further performance improvements on hash aggregation with small groups

nevi-me commented on pull request #9271:
URL: https://github.com/apache/arrow/pull/9271#issuecomment-765375980


   > I found the "offending" code is this function in `array/data.rs` which does a `self.clone()`.
   
   This relates to the other discussion that we had on how slicing an array does a clone without propagating offset information to child_data and buffers.
   
   I find it interesting though that `self.clone()` would cost us so much. If you were to clone an array, and inspect the original and the cloned, the buffers point to the same location in memory. I thought that's what zero-copying would give us.
   
   Is that not the case?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org