You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Vivek <vi...@collab.net> on 2005/06/02 04:26:47 UTC
Re: Review of patch in issue #2301 (test for -rDATE with diff).
On Wed, 2005-06-01 at 03:22, kfogel@collab.net wrote:
> I don't have the original post handy, but here is a review of the
> patch attached to issue #2301.
This was posted sometime back. :-)
>
> Please leave a comma after the last element, so the next diff can
> affect only one line instead of two. (It should have been this way
> before, I don't know why it was not.)
Thanks for the detailed review Karl. I did this patch as a test case for
the GNU date/time bug. Is going for a V2 worth it?
And Thanks for committing patch of issue #2300.
Vivek.
>
> -Karl
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Review of patch in issue #2301 (test for -rDATE with diff).
Posted by kf...@collab.net.
Vivek <vi...@collab.net> writes:
> On Wed, 2005-06-01 at 03:22, kfogel@collab.net wrote:
> > I don't have the original post handy, but here is a review of the
> > patch attached to issue #2301.
>
> This was posted sometime back. :-)
Yes. The wheels of code review grind slow, but they grind exceeding fine.
> > Please leave a comma after the last element, so the next diff can
> > affect only one line instead of two. (It should have been this way
> > before, I don't know why it was not.)
>
> Thanks for the detailed review Karl. I did this patch as a test case for
> the GNU date/time bug. Is going for a V2 worth it?
> And Thanks for committing patch of issue #2300.
If it's to test a bug for regression, then I think a V2 is worth it.
Make sure the test describes the bug it's testing for, though.
Let's not put it in diff_tests.py, since it's really got nothing to do
with testing diff. Instead, I think it would be best to make a new
date_tests.py. Even though it's only one test (for now), that would
keep things organized and clear.
Best,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org