[GitHub] [helix] jiajunwang commented on issue #395: Fix the CallbackHandler registration logic in DistributedLeaderElection

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #395: Fix the CallbackHandler registration logic in DistributedLeaderElection
URL: https://github.com/apache/helix/pull/395#issuecomment-519804111
 
 
   > From you code, my understanding is you do the acquiring leadership once anyway. What if it is already acquired by itself? Will that cause any bad effects?
   
   As commented in the code, the acquiring leadership block has to be idempotent. There seems to be no other way if we are not going to rewrite the DistributedLeaderElection class.
   The current logic is still safe. But in general, I think DistributedLeaderElection does need some heavy refactoring. Just not in this fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org