You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/06 01:45:44 UTC

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #3443: drivers/input: Organize input drivers by category

gustavonihei opened a new pull request #3443:
URL: https://github.com/apache/incubator-nuttx/pull/3443


   ## Summary
   This PR intends to organize the input drivers by creating new higher level categories for TOUCHSCREEN, JOYSTICK and
   KEYBOARD devices. This eases the dependency filtering for a specific input subgroup.
   
   Reference:
   https://github.com/apache/incubator-nuttx-apps/pull/666#issuecomment-813711509
   
   ## Impact
   New configuration option added to boards that supported any of the device drivers now categorized as TOUCHSCREEN, JOYSTICK or KEYBOARD.
   
   ## Testing
   No functional change.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #3443: drivers/input: Organize input drivers by category

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #3443:
URL: https://github.com/apache/incubator-nuttx/pull/3443#issuecomment-813794942


   > What about having the drivers select the input class instead? 
   
   This is exactly what @patacongo suggested in the other PR.
   I think this is also a good idea, although I believe that, for consistency, we would need to extend this refactor to the top `CONFIG_INPUT` option, changing it from `menuconfig` to a non-visible `bool`.
   Currently the user is able to enable the Input subsystem without including any input driver, for which I can't understand if there is a valid use case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei closed pull request #3443: drivers/input: Organize input drivers by category

Posted by GitBox <gi...@apache.org>.
gustavonihei closed pull request #3443:
URL: https://github.com/apache/incubator-nuttx/pull/3443


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #3443: drivers/input: Organize input drivers by category

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #3443:
URL: https://github.com/apache/incubator-nuttx/pull/3443#issuecomment-815272747


   Closing this PR in favor of #3475.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #3443: drivers/input: Organize input drivers by category

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3443:
URL: https://github.com/apache/incubator-nuttx/pull/3443#issuecomment-813786122


   What about having the drivers select the input class instead? We also need to include the USB  HID devices for keyboard and mouse


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei edited a comment on pull request #3443: drivers/input: Organize input drivers by category

Posted by GitBox <gi...@apache.org>.
gustavonihei edited a comment on pull request #3443:
URL: https://github.com/apache/incubator-nuttx/pull/3443#issuecomment-813794942


   > What about having the drivers select the input class instead? 
   
   This is exactly what @patacongo suggested in the other PR.
   I think this is also a good idea, although I believe that, for consistency, we would need to extend this refactor to the top `CONFIG_INPUT` option, changing it from `menuconfig` to a non-visible `bool`, that would be selected when any of the input classes is also selected.
   Currently the user is able to enable the Input subsystem without including any input driver, for which I can't understand if there is a valid use case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org