You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2024/10/25 09:55:02 UTC
[PR] Support some admin commands in table model [iotdb]
JackieTien97 opened a new pull request, #13918:
URL: https://github.com/apache/iotdb/pull/13918
Support the following commands:
1. SHOW CURRENT_SQL_DIALECT
2. SHOW CURRENT_USER
3. SHOW CURRENT_DATABASE
4. SHOW VERSION
5. SHOW VARIABLES
6. SHOW CLUSTERID
7. SHOW CURRENT_TIMESTAMP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support some admin commands in table model [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13918:
URL: https://github.com/apache/iotdb/pull/13918#issuecomment-2437511154
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13918?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `3.72093%` with `207 lines` in your changes missing coverage. Please review.
> Project coverage is 39.67%. Comparing base [(`77a2dd7`)](https://app.codecov.io/gh/apache/iotdb/commit/77a2dd7232d9193c78b9be31eeff702315ce346b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9f0be44`)](https://app.codecov.io/gh/apache/iotdb/commit/9f0be44ab05a18b6c0e8e6076694780f29ba7a8d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/13918?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...cution/config/session/ShowCurrentDatabaseTask.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fexecution%2Fconfig%2Fsession%2FShowCurrentDatabaseTask.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9leGVjdXRpb24vY29uZmlnL3Nlc3Npb24vU2hvd0N1cnJlbnREYXRhYmFzZVRhc2suamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...tion/config/session/ShowCurrentSqlDialectTask.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fexecution%2Fconfig%2Fsession%2FShowCurrentSqlDialectTask.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9leGVjdXRpb24vY29uZmlnL3Nlc3Npb24vU2hvd0N1cnJlbnRTcWxEaWFsZWN0VGFzay5qYXZh) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../execution/config/session/ShowCurrentUserTask.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fexecution%2Fconfig%2Fsession%2FShowCurrentUserTask.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9leGVjdXRpb24vY29uZmlnL3Nlc3Npb24vU2hvd0N1cnJlbnRVc2VyVGFzay5qYXZh) | 0.00% | [18 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ion/config/executor/ClusterConfigTaskExecutor.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fexecution%2Fconfig%2Fexecutor%2FClusterConfigTaskExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9leGVjdXRpb24vY29uZmlnL2V4ZWN1dG9yL0NsdXN0ZXJDb25maWdUYXNrRXhlY3V0b3IuamF2YQ==) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../plan/execution/config/TableConfigTaskVisitor.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Fexecution%2Fconfig%2FTableConfigTaskVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9leGVjdXRpb24vY29uZmlnL1RhYmxlQ29uZmlnVGFza1Zpc2l0b3IuamF2YQ==) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...yengine/plan/relational/sql/util/SqlFormatter.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fsql%2Futil%2FSqlFormatter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3NxbC91dGlsL1NxbEZvcm1hdHRlci5qYXZh) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...yengine/plan/relational/sql/ast/ShowClusterId.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fsql%2Fast%2FShowClusterId.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3NxbC9hc3QvU2hvd0NsdXN0ZXJJZC5qYXZh) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/plan/relational/sql/ast/ShowCurrentDatabase.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fsql%2Fast%2FShowCurrentDatabase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3NxbC9hc3QvU2hvd0N1cnJlbnREYXRhYmFzZS5qYXZh) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...plan/relational/sql/ast/ShowCurrentSqlDialect.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fsql%2Fast%2FShowCurrentSqlDialect.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3NxbC9hc3QvU2hvd0N1cnJlbnRTcWxEaWFsZWN0LmphdmE=) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../plan/relational/sql/ast/ShowCurrentTimestamp.java](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fqueryengine%2Fplan%2Frelational%2Fsql%2Fast%2FShowCurrentTimestamp.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcXVlcnllbmdpbmUvcGxhbi9yZWxhdGlvbmFsL3NxbC9hc3QvU2hvd0N1cnJlbnRUaW1lc3RhbXAuamF2YQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [9 more](https://app.codecov.io/gh/apache/iotdb/pull/13918?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #13918 +/- ##
============================================
- Coverage 39.76% 39.67% -0.10%
Complexity 71 71
============================================
Files 4163 4178 +15
Lines 263483 264131 +648
Branches 32100 32174 +74
============================================
+ Hits 104780 104786 +6
- Misses 158703 159345 +642
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13918?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support some admin commands in table model [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #13918:
URL: https://github.com/apache/iotdb/pull/13918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support some admin commands in table model [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13918:
URL: https://github.com/apache/iotdb/pull/13918#issuecomment-2437391047
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13918) **Quality Gate failed**
Failed conditions
 [13.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13918&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13918)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support some admin commands in table model [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13918:
URL: https://github.com/apache/iotdb/pull/13918#issuecomment-2437427999
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13918) **Quality Gate failed**
Failed conditions
 [13.5% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13918&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13918)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org