[GitHub] [cassandra-accord] dcapwell commented on a diff in pull request #33: Immutable state

["dcapwell (via GitHub)" <gi...@apache.org>]

dcapwell commented on code in PR #33:
URL: https://github.com/apache/cassandra-accord/pull/33#discussion_r1095236419


##########
accord-core/src/main/java/accord/primitives/TxnId.java:
##########
@@ -27,6 +28,9 @@
 
 public class TxnId extends Timestamp
 {
+//    public static final TxnId TARGET = new TxnId(1, 2, 3, new Node.Id(4));
+    public static final TxnId TARGET = new TxnId(1, 4, 3, new Node.Id(2));

Review Comment:
   should we revert?  This is dead code



##########
accord-core/src/main/java/accord/utils/SortedArrays.java:
##########
@@ -21,6 +21,7 @@
 import java.util.Arrays;
 import java.util.Comparator;
 import java.util.function.IntFunction;
+import java.util.function.Predicate;

Review Comment:
   unused import



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org