You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/08/07 13:15:44 UTC
[GitHub] [cassandra-website] msacks-dev opened a new pull request, #157: Msacks dev/trunk
msacks-dev opened a new pull request, #157:
URL: https://github.com/apache/cassandra-website/pull/157
this should be squashed and cleaner pull request with the proper link. please review and close PR 143 as it has incorrect code. this has been built and tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#issuecomment-1219477550
merged manually with 11349c1a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] msacks-dev commented on pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
msacks-dev commented on PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#issuecomment-1219071736
i added the whitespace and tested locally, should be good now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#discussion_r944547069
##########
site-content/source/modules/ROOT/pages/development/documentation.adoc:
##########
@@ -18,7 +18,7 @@ instead of visual editors (which some people would call good news).
Antora processes http://www.asciidoc.org[AsciiDoc], the markup language used to generate our documentation.
Markup languages allow you to format text using certain syntax elements.
Your document structure will also have to follow specific conventions.
-Feel free to take a look at https://cassandra.apache.org/doc/latest/[existing documents] to get a better idea how we structure our documents.
+Feel free to take a look at link:/doc/latest/[existing documents] to get a better idea how we structure our documents.
Review Comment:
can you try the following please
```suggestion
Feel free to take a look at link:/doc/[existing documents] to get a better idea how we structure our documents.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#discussion_r944335306
##########
site-content/source/modules/ROOT/pages/development/documentation.adoc:
##########
@@ -18,7 +18,7 @@ instead of visual editors (which some people would call good news).
Antora processes http://www.asciidoc.org[AsciiDoc], the markup language used to generate our documentation.
Markup languages allow you to format text using certain syntax elements.
Your document structure will also have to follow specific conventions.
-Feel free to take a look at https://cassandra.apache.org/doc/latest/[existing documents] to get a better idea how we structure our documents.
+Feel free to take a look at link:/doc/latest/[existing documents] to get a better idea how we structure our documents.
Review Comment:
this changed the wrong link. we want this one to remain as `https://cassandra.apache.org/doc/` (to demonstrate the versions of docs we have available, i.e. "the structure")
it was this [one](url) that needed reverting https://github.com/apache/cassandra-website/pull/157/files#r939723811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#discussion_r939723908
##########
site-content/source/modules/ROOT/pages/development/documentation.adoc:
##########
@@ -8,18 +8,17 @@
The official Cassandra documentation lives in the project's git
repository.
We use a static site generator, http://www.antora.org/[Antora], to create pages hosted at
-link:/doc/latest/[cassandra.apache.org].
-
+https://cassandra.apache.org/docs/latest/[cassandra.apache.org].
<!-- You'll also find developer-centric content about Cassandra internals in our
retired https://wiki.apache.org/cassandra[wiki] (not covered by this
guide). -->
Using a static site generator often requires the use of a markup language
instead of visual editors (which some people would call good news).
-Antora processes http://www.asciidoc.org[Ascidoc], the markup language used to generate our documentation.
+Antora processes http://www.asciidoc.org[AsciiDoc], the markup language used to generate our documentation.
Markup languages allow you to format text using certain syntax elements.
Your document structure will also have to follow specific conventions.
-Feel free to take a look at http://cassandra.apache.org/docs[existing documents] to get a better idea how we structure our documents.
+Feel free to take a look at https://cassandra.apache.org/doc/latest/[existing documents] to get a better idea how we structure our documents.
Review Comment:
Please remove the `latest/` suffix, as agreed [here](https://github.com/apache/cassandra-website/pull/143#discussion_r904164956).
```suggestion
Feel free to take a look at https://cassandra.apache.org/doc/[existing documents] to get a better idea how we structure our documents.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#discussion_r939723811
##########
site-content/source/modules/ROOT/pages/development/documentation.adoc:
##########
@@ -8,18 +8,17 @@
The official Cassandra documentation lives in the project's git
repository.
We use a static site generator, http://www.antora.org/[Antora], to create pages hosted at
-link:/doc/latest/[cassandra.apache.org].
-
+https://cassandra.apache.org/docs/latest/[cassandra.apache.org].
Review Comment:
This wasn't broken before, and `link:` is to be favoured. Can you revert this change please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#discussion_r944335306
##########
site-content/source/modules/ROOT/pages/development/documentation.adoc:
##########
@@ -18,7 +18,7 @@ instead of visual editors (which some people would call good news).
Antora processes http://www.asciidoc.org[AsciiDoc], the markup language used to generate our documentation.
Markup languages allow you to format text using certain syntax elements.
Your document structure will also have to follow specific conventions.
-Feel free to take a look at https://cassandra.apache.org/doc/latest/[existing documents] to get a better idea how we structure our documents.
+Feel free to take a look at link:/doc/latest/[existing documents] to get a better idea how we structure our documents.
Review Comment:
this changed the wrong link. we want this one to remain as `https://cassandra.apache.org/doc/` (to demonstrate the versions of docs we have available, i.e. "the structure")
it was this [one](https://github.com/apache/cassandra-website/pull/157/files#r939723811) that needed reverting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on a diff in pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on code in PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#discussion_r945273955
##########
site-content/source/modules/ROOT/pages/development/documentation.adoc:
##########
@@ -9,17 +9,16 @@ The official Cassandra documentation lives in the project's git
repository.
We use a static site generator, http://www.antora.org/[Antora], to create pages hosted at
link:/doc/latest/[cassandra.apache.org].
-
Review Comment:
We need this blank line restored. (i.e. please don't remove it)
Because removing it makes it look like…
<img width="971" alt="Screenshot 2022-08-14 at 13 24 34" src="https://user-images.githubusercontent.com/559444/184534506-97f72802-be9f-4af8-8620-6114dba4ebd1.png">
while originally it looks like (which is how we want it)
<img width="971" alt="Screenshot 2022-08-14 at 13 26 09" src="https://user-images.githubusercontent.com/559444/184534548-da0b227f-0682-45e2-b310-9c270d258b1b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] msacks-dev commented on a diff in pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
msacks-dev commented on code in PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#discussion_r940763284
##########
site-content/source/modules/ROOT/pages/development/documentation.adoc:
##########
@@ -8,18 +8,17 @@
The official Cassandra documentation lives in the project's git
repository.
We use a static site generator, http://www.antora.org/[Antora], to create pages hosted at
-link:/doc/latest/[cassandra.apache.org].
-
+https://cassandra.apache.org/docs/latest/[cassandra.apache.org].
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever commented on pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on PR #157:
URL: https://github.com/apache/cassandra-website/pull/157#issuecomment-1219453356
Love it! Thanks for sticking at it @msacks-dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-website] michaelsembwever closed pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #157: CASSANDRA-17699 Updated broken link in development/documentation.html (updated)
URL: https://github.com/apache/cassandra-website/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org