You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Weiwei Yang (JIRA)" <ji...@apache.org> on 2017/12/13 05:30:00 UTC

[jira] [Comment Edited] (YARN-7647) NM print inappropriate error log when node-labels is enabled

    [ https://issues.apache.org/jira/browse/YARN-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288732#comment-16288732 ] 

Weiwei Yang edited comment on YARN-7647 at 12/13/17 5:29 AM:
-------------------------------------------------------------

Committed the patch to branch-2, branch-2.8, branch-2.9, branch-3.0 and trunk. Thanks [~fly_in_gis] for the contribution.


was (Author: cheersyang):
Committed the patch to branch-2.9, branch-3.0 and trunk. Thanks [~fly_in_gis] for the contribution.

> NM print inappropriate error log when node-labels is enabled
> ------------------------------------------------------------
>
>                 Key: YARN-7647
>                 URL: https://issues.apache.org/jira/browse/YARN-7647
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.8.0, 3.0.0-alpha1
>            Reporter: Yang Wang
>            Assignee: Yang Wang
>            Priority: Minor
>             Fix For: 2.8.2, 3.1.0, 2.9.1, 3.0.1
>
>         Attachments: YARN-7647.001.patch
>
>
> {code:title=NodeStatusUpdaterImpl.java}
>       ... ...
>       if (response.getAreNodeLabelsAcceptedByRM() && LOG.isDebugEnabled()) {
>           LOG.debug("Node Labels {" + StringUtils.join(",", previousNodeLabels)
>               + "} were Accepted by RM ");
>         } else {
>           // case where updated labels from NodeLabelsProvider is sent to RM and
>           // RM rejected the labels
>           LOG.error(
>               "NM node labels {" + StringUtils.join(",", previousNodeLabels)
>                   + "} were not accepted by RM and message from RM : "
>                   + response.getDiagnosticsMessage());
>         }
>       ... ...
> {code}
> When LOG.isDebugEnabled() is false, NM will always print error log. It is an obvious error and is so misleading.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org