[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11470: [Fix-11465] RPC requests are placed after transaction commit

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #11470:
URL: https://github.com/apache/dolphinscheduler/pull/11470#discussion_r949758164


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterSchedulerBootstrap.java:
##########
@@ -232,6 +247,24 @@ private List<ProcessInstance> command2ProcessInstance(List<Command> commands) th
         return processInstances;
     }
 
+    private void sendRpcCommand(ProcessInstance processInstance) {

Review Comment:
   Suggest move this method in `handleCommand`, otherwise, we need to execute sendRpcCommand in all other place when we  execute handleCommand.
   
   We can just split handleCommand into two method: `handleCommandInDB` and `sendRpcCommand`, handleCommandInDb can have transaction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org