You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/28 17:06:50 UTC

[GitHub] [flink-kubernetes-operator] pvary opened a new pull request, #456: FLINK-30222: Operator should handle 'kubernetes' as a valid setting for the 'high-availability' config key

pvary opened a new pull request, #456:
URL: https://github.com/apache/flink-kubernetes-operator/pull/456

   ## What is the purpose of the change
   
   Since 1.16 it is possible to set `kubernetes` as a value for `high-availability`
   Operator needs to accept this as a valid value
   
   ## Brief change log
   
   - Changed the `FlinkUtils.isKubernetesHAActivated` to accept the new value
   - Added a new test for it
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   
   - Added a new unit tests for the config checking
   - Also run manual testing using the e2e tests to create a cluster using v1_16 flink and using the new config
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #456: FLINK-30222: Operator should handle 'kubernetes' as a valid setting for the 'high-availability' config key

Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #456:
URL: https://github.com/apache/flink-kubernetes-operator/pull/456


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #456: FLINK-30222: Operator should handle 'kubernetes' as a valid setting for the 'high-availability' config key

Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #456:
URL: https://github.com/apache/flink-kubernetes-operator/pull/456#issuecomment-1330486354

   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org