You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nitheesh-daram (via GitHub)" <gi...@apache.org> on 2023/05/21 17:34:10 UTC
[GitHub] [eventmesh] nitheesh-daram opened a new pull request, #3995: [ISSUE #3960 ]
nitheesh-daram opened a new pull request, #3995:
URL: https://github.com/apache/eventmesh/pull/3995
This PR Resolves #3960
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3995: [ISSUE #3960 ]Code optimization.[RegistryHandler]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3995:
URL: https://github.com/apache/eventmesh/pull/3995#issuecomment-1560675752
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3995?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3995](https://app.codecov.io/gh/apache/eventmesh/pull/3995?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0f91646) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/1798e1f9b5cc212ec75425325bdfb3d1502a4ab5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1798e1f) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 0f91646 differs from pull request most recent head 289865b. Consider uploading reports for the commit 289865b to get more accurate results
```diff
@@ Coverage Diff @@
## master #3995 +/- ##
============================================
- Coverage 14.24% 14.23% -0.02%
Complexity 1320 1320
============================================
Files 579 579
Lines 28958 28952 -6
Branches 2815 2800 -15
============================================
- Hits 4125 4121 -4
+ Misses 24441 24440 -1
+ Partials 392 391 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3995?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...entmesh/runtime/admin/handler/RegistryHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3995?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVnaXN0cnlIYW5kbGVyLmphdmE=) | `7.27% <0.00%> (-0.14%)` | :arrow_down: |
| [...ventmesh/runtime/constants/EventMeshConstants.java](https://app.codecov.io/gh/apache/eventmesh/pull/3995?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvbnN0YW50cy9FdmVudE1lc2hDb25zdGFudHMuamF2YQ==) | `0.00% <ø> (ø)` | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3995/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3995: [ISSUE #3960 ]Code optimization.[RegistryHandler]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3995:
URL: https://github.com/apache/eventmesh/pull/3995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] nitheesh-daram commented on pull request #3995: [ISSUE #3960 ]
Posted by "nitheesh-daram (via GitHub)" <gi...@apache.org>.
nitheesh-daram commented on PR #3995:
URL: https://github.com/apache/eventmesh/pull/3995#issuecomment-1557565833
@mxsm thanks for reviewing ,I'll update them ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] mxsm commented on pull request #3995: [ISSUE #3960 ]
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #3995:
URL: https://github.com/apache/eventmesh/pull/3995#issuecomment-1557510623
Hi @nitheesh-daram The code is fine. I have a small suggestion. Please format the PR title as [ISSUE #issue number] xxxx, where xxxx represents the specific changes made. This makes it look clearer and more concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org