You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/08/06 13:07:03 UTC
[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3688: ARTEMIS-3414 Disable OpenWire advisory support as default created configuration on CLI
franz1981 commented on a change in pull request #3688:
URL: https://github.com/apache/activemq-artemis/pull/3688#discussion_r684220185
##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java
##########
@@ -283,6 +283,12 @@
@Option(name = "--staticCluster", description = "Cluster node connectors list, separated by comma: Example \"tcp://server:61616,tcp://server2:61616,tcp://server3:61616\"")
String staticNode;
+ @Option(name = "--support-advisory", description = "Set supportAdvisory=true for the main 'artemis' acceptor on OPENWIRE protocol (Default: false)")
+ boolean supportAdvisory = false;
+
+ @Option(name = "--suppress-internal-management-objects", description = "Set suppressInternalManagementObjects=true for the main 'artemis' acceptor on OPENWIRE protocol (Default: false)")
+ boolean suppressInternalManagementObjects = false;
Review comment:
By default people won't even notice, but I have left them to be separated as the acceptor params are (can be tuned singularly)
##########
File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java
##########
@@ -283,6 +283,12 @@
@Option(name = "--staticCluster", description = "Cluster node connectors list, separated by comma: Example \"tcp://server:61616,tcp://server2:61616,tcp://server3:61616\"")
String staticNode;
+ @Option(name = "--support-advisory", description = "Set supportAdvisory=true for the main 'artemis' acceptor on OPENWIRE protocol (Default: false)")
+ boolean supportAdvisory = false;
+
+ @Option(name = "--suppress-internal-management-objects", description = "Set suppressInternalManagementObjects=true for the main 'artemis' acceptor on OPENWIRE protocol (Default: false)")
+ boolean suppressInternalManagementObjects = false;
Review comment:
By default people won't even notice (if they won't set it), but I have left them to be separated as the acceptor params are (can be tuned singularly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org