You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by gb...@apache.org on 2023/04/05 09:05:24 UTC

svn commit: r1908984 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/generators/mod_cgid.c

Author: gbechis
Date: Wed Apr  5 09:05:24 2023
New Revision: 1908984

URL: http://svn.apache.org/viewvc?rev=1908984&view=rev
Log:
log an error when ap_runtime_dir_relative fails.
spotted by rpluem@

Modified:
    httpd/httpd/trunk/docs/log-message-tags/next-number
    httpd/httpd/trunk/modules/generators/mod_cgid.c

Modified: httpd/httpd/trunk/docs/log-message-tags/next-number
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/next-number?rev=1908984&r1=1908983&r2=1908984&view=diff
==============================================================================
--- httpd/httpd/trunk/docs/log-message-tags/next-number (original)
+++ httpd/httpd/trunk/docs/log-message-tags/next-number Wed Apr  5 09:05:24 2023
@@ -1 +1 @@
-10423
+10424

Modified: httpd/httpd/trunk/modules/generators/mod_cgid.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_cgid.c?rev=1908984&r1=1908983&r2=1908984&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/generators/mod_cgid.c (original)
+++ httpd/httpd/trunk/modules/generators/mod_cgid.c Wed Apr  5 09:05:24 2023
@@ -1059,8 +1059,11 @@ static int cgid_init(apr_pool_t *p, apr_
 
         parent_pid = getpid();
         tmp_sockname = ap_runtime_dir_relative(p, sockname);
-        if (!tmp_sockname)
+        if (!tmp_sockname) {
+            ap_log_error(APLOG_MARK, APLOG_ERR, 0, main_server, APLOGNO(10423)
+                         "Invalid socket path %s", sockname);
             return DECLINED;
+        }
         if (strlen(tmp_sockname) > sizeof(server_addr->sun_path) - 1) {
             tmp_sockname[sizeof(server_addr->sun_path)] = '\0';
             ap_log_error(APLOG_MARK, APLOG_ERR, 0, main_server, APLOGNO(01254)