You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2024/03/21 17:25:54 UTC
[PR] fix(docker): error around missing requirements/base.txt [superset]
mistercrunch opened a new pull request, #27608:
URL: https://github.com/apache/superset/pull/27608
Closes https://github.com/apache/superset/issues/27606
### SUMMARY
I'm unclear on why exactly CI succeeded while this was an issue running
locally. I'm guessing it has to do with `--mount` and how it works
around caching, so I'm moving to a COPY-based approach, which is more
standard and easy to reason about. It also leaves a useful artefact on
the machine as to how it was built. It does add a tiny layer and payload
on the image, but it's super cheap for the utility/introspection it provides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): error around missing requirements/base.txt [superset]
Posted by "guizsantos (via GitHub)" <gi...@apache.org>.
guizsantos commented on PR #27608:
URL: https://github.com/apache/superset/pull/27608#issuecomment-2015850155
I think the issue here was that `requirements/development.txt` references `requirements/base.txt` and since `base.txt` is mounted during runtime, it is not available when the second pip install is running. I believe adding `--mount=type=bind,target=./requirements/base.txt,src=./requirements/base.txt \` in addition to the `development.txt` mount fixes the issue. I liked the mount base approach, much prefer it over the `COPY`-based one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): error around missing requirements/base.txt [superset]
Posted by "xyy94813 (via GitHub)" <gi...@apache.org>.
xyy94813 commented on PR #27608:
URL: https://github.com/apache/superset/pull/27608#issuecomment-2020336963
Hi,
I want to confirm if this PR fixes follow bug in CI of my PR??
```
ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements/testing.txt'
```
https://github.com/apache/superset/actions/runs/8235126931/job/22862070545?pr=26180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): error around missing requirements/base.txt [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #27608:
URL: https://github.com/apache/superset/pull/27608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): error around missing requirements/base.txt [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #27608:
URL: https://github.com/apache/superset/pull/27608#issuecomment-2020701436
@xyy94813 rebase and you should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): error around missing requirements/base.txt [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #27608:
URL: https://github.com/apache/superset/pull/27608#issuecomment-2015856243
Oh right, totally, that was the issue.
Originally in my PR I was confused as to why CI didn't fail / catch this issue in the first place which I found along the way and commented on the PR body ->
> I found the issue as to why this defect in the dockerfile wasn't caught in CI, it's because the --preset dev parameter was not getting passed down properly, and resulting in targeting the lean layer, avoid that issue altogether. I fixed supersetbot, added unit tests and published a new version on npm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org