You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/22 02:37:29 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25202: [SPARK-28289][SQL][PYTHON][TESTS] Convert and port 'union.sql' into UDF test base

HyukjinKwon commented on a change in pull request #25202: [SPARK-28289][SQL][PYTHON][TESTS] Convert and port 'union.sql' into UDF test base
URL: https://github.com/apache/spark/pull/25202#discussion_r305656765
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/udf/udf-union.sql
 ##########
 @@ -0,0 +1,56 @@
+-- This test file was converted from union.sql.
+
+CREATE OR REPLACE TEMPORARY VIEW t1 AS VALUES (1, 'a'), (2, 'b') tbl(c1, c2);
+CREATE OR REPLACE TEMPORARY VIEW t2 AS VALUES (1.0, 1), (2.0, 4) tbl(c1, c2);
+
+-- Simple Union
+SELECT *
+FROM   (SELECT * FROM t1
 
 Review comment:
   Can we insert UDF like `udf(c1), udf(c2)`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org