You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/12 07:21:09 UTC
[GitHub] [pulsar] wongkimshing opened a new issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client
wongkimshing opened a new issue #7800:
URL: https://github.com/apache/pulsar/issues/7800
**Is your enhancement request related to a problem? Please describe.**
When we wanna receive messages with **KEY_SHARED** mode with Java consumer, we found there is no **KEY_BASED** option from **BatchBuilder** for C++ producer. It's kind of frustrated for the integration between C++ & Java programs.
**Describe the solution you'd like**
Add **KEY_SHARED** mode for C++ client and **KEY_BASED** option from **BatchBuilder** as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #7800:
URL: https://github.com/apache/pulsar/issues/7800#issuecomment-673872607
@wongkimshing
First make it clear that KEY_SHARED is a subscription mode for consumers, key based batching is a feature of batching for producers. You can send messages **without batching** by C++ client, and consume these messages using KEY_SHARED subscription by Java client.
1. I mean C++ **consumer** can subscribe topics with KEY_SHARED mode.
2. Yeah, I'd like to continue the [development](https://github.com/BewareMyPower/pulsar/commits/key-based-batch-dev). I may just have more time after this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #7800:
URL: https://github.com/apache/pulsar/issues/7800#issuecomment-1075858045
Close this issue since it is supported now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #7800:
URL: https://github.com/apache/pulsar/issues/7800#issuecomment-672841198
1. You can set consumer type of `ConsumerConfiguration` to use key shared subscription.
2. C++ client doesn't support key based batching yet. I did some work about key based batching last month, but I'm a little busy recently so I didn't continue. It's not a difficult feature but it needs much code refactoring for C++ client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #7800:
URL: https://github.com/apache/pulsar/issues/7800#issuecomment-688257810
I've just pushed a PR #7996 to support key based batching. There're a lot of changes so it may take some time to review.
You can see [KeySharedConsumerTest.cc](https://github.com/apache/pulsar/blob/bf55c95b5ff65e7ed2eb78617f2e183b77d47aa4/pulsar-client-cpp/tests/KeySharedConsumerTest.cc) as an example. Just change the batching type of producer:
```c++
ProducerConfiguration() //
.setBatchingType(ProducerConfiguration::KeyBasedBatching) //
/* set other configs... */
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower closed issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client
Posted by GitBox <gi...@apache.org>.
BewareMyPower closed issue #7800:
URL: https://github.com/apache/pulsar/issues/7800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wongkimshing commented on issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client
Posted by GitBox <gi...@apache.org>.
wongkimshing commented on issue #7800:
URL: https://github.com/apache/pulsar/issues/7800#issuecomment-673869585
@BewareMyPower
1. You mean Java consumer with KEY_SHARED mode and C++ producer without KEY_SHARED mode are working well for KEY_SHARED?
2. Could you please take some time on it? Really appreciate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org