You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Devaraj Das <dd...@apache.org> on 2011/03/29 19:26:04 UTC
Review Request: HIVE-1988
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/528/
-----------------------------------------------------------
Review request for hive.
Summary
-------
Fixes to some security issues discussed in HIVE-1988
This addresses bug HIVE-1988.
https://issues.apache.org/jira/browse/HIVE-1988
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 1085623
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1085623
Diff: https://reviews.apache.org/r/528/diff
Testing
-------
New unit test added and that passes.
Thanks,
Devaraj
Re: Review Request: HIVE-1988
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/528/#review394
-----------------------------------------------------------
Ship it!
+1
- Amareshwari
On 2011-04-05 21:24:34, Devaraj Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/528/
> -----------------------------------------------------------
>
> (Updated 2011-04-05 21:24:34)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> Fixes to some security issues discussed in HIVE-1988
>
>
> This addresses bug HIVE-1988.
> https://issues.apache.org/jira/browse/HIVE-1988
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1089155
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1089155
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java 1089155
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1089155
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1089155
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1089155
>
> Diff: https://reviews.apache.org/r/528/diff
>
>
> Testing
> -------
>
> New unit test added and that passes. All unit tests passed.
>
>
> Thanks,
>
> Devaraj
>
>
Re: Review Request: HIVE-1988
Posted by Devaraj Das <dd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/528/
-----------------------------------------------------------
(Updated 2011-04-05 21:24:34.129643)
Review request for hive.
Changes
-------
Addressed Amareshwari's comments.
Summary
-------
Fixes to some security issues discussed in HIVE-1988
This addresses bug HIVE-1988.
https://issues.apache.org/jira/browse/HIVE-1988
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1089155
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1089155
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java 1089155
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1089155
http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1089155
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1089155
Diff: https://reviews.apache.org/r/528/diff
Testing
-------
New unit test added and that passes. All unit tests passed.
Thanks,
Devaraj
Re: Review Request: HIVE-1988
Posted by Devaraj Das <dd...@apache.org>.
> On 2011-04-05 07:52:15, Amareshwari Sriramadasu wrote:
> > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 152
> > <https://reviews.apache.org/r/528/diff/2/?file=14844#file14844line152>
> >
> > HadoopShims.isSecureShimImpl() is not called anywhere else. Shall we remove it if not required anymore?
I suggest we leave it there. This seems like a useful method, and I am actually using it in another patch.
> On 2011-04-05 07:52:15, Amareshwari Sriramadasu wrote:
> > http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java, lines 144-156
> > <https://reviews.apache.org/r/528/diff/2/?file=14850#file14850line144>
> >
> > Do you want to move this into setup(), as it is common in both testcases?
Done
> On 2011-04-05 07:52:15, Amareshwari Sriramadasu wrote:
> > http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java, lines 192-209
> > <https://reviews.apache.org/r/528/diff/2/?file=14850#file14850line192>
> >
> > code looks duplicated. Can it be refactored by passing group names to a method?
Done
- Devaraj
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/528/#review386
-----------------------------------------------------------
On 2011-03-29 10:26:38, Devaraj Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/528/
> -----------------------------------------------------------
>
> (Updated 2011-03-29 10:26:38)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> Fixes to some security issues discussed in HIVE-1988
>
>
> This addresses bug HIVE-1988.
> https://issues.apache.org/jira/browse/HIVE-1988
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 1085623
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1085623
>
> Diff: https://reviews.apache.org/r/528/diff
>
>
> Testing
> -------
>
> New unit test added and that passes. All unit tests passed.
>
>
> Thanks,
>
> Devaraj
>
>
Re: Review Request: HIVE-1988
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/528/#review386
-----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/528/#comment734>
HadoopShims.isSecureShimImpl() is not called anywhere else. Shall we remove it if not required anymore?
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
<https://reviews.apache.org/r/528/#comment735>
Do you want to move this into setup(), as it is common in both testcases?
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
<https://reviews.apache.org/r/528/#comment736>
code looks duplicated. Can it be refactored by passing group names to a method?
- Amareshwari
On 2011-03-29 10:26:38, Devaraj Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/528/
> -----------------------------------------------------------
>
> (Updated 2011-03-29 10:26:38)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> Fixes to some security issues discussed in HIVE-1988
>
>
> This addresses bug HIVE-1988.
> https://issues.apache.org/jira/browse/HIVE-1988
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 1085623
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1085623
> http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1085623
>
> Diff: https://reviews.apache.org/r/528/diff
>
>
> Testing
> -------
>
> New unit test added and that passes. All unit tests passed.
>
>
> Thanks,
>
> Devaraj
>
>
Re: Request for review
Posted by Devaraj Das <dd...@yahoo-inc.com>.
Sorry, didn't mean to send it on the dev list :-( . Of course any other committer is welcome to review :-)
On 4/1/11 8:20 AM, "Devaraj Das" <dd...@yahoo-inc.com> wrote:
Hi Amareshwari, could you please take a look at the patch for hive-1988. Since you are the only hive committer at Y!, hence this request :-)
Devaraj
On 3/29/11 10:26 AM, "Devaraj Das" <dd...@apache.org> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/528/
Review request for hive.
By Devaraj Das.
Updated 2011-03-29 10:26:38.374832
Description
Fixes to some security issues discussed in HIVE-1988
Testing (updated)
New unit test added and that passes. All unit tests passed.
Bugs: HIVE-1988 <https://issues.apache.org/jira/browse/HIVE-1988>
Diffs
* http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java (1085623)
View Diff <https://reviews.apache.org/r/528/diff/>
Request for review
Posted by Devaraj Das <dd...@yahoo-inc.com>.
Hi Amareshwari, could you please take a look at the patch for hive-1988. Since you are the only hive committer at Y!, hence this request :-)
Devaraj
On 3/29/11 10:26 AM, "Devaraj Das" <dd...@apache.org> wrote:
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/528/
Review request for hive.
By Devaraj Das.
Updated 2011-03-29 10:26:38.374832
Description
Fixes to some security issues discussed in HIVE-1988
Testing (updated)
New unit test added and that passes. All unit tests passed.
Bugs: HIVE-1988 <https://issues.apache.org/jira/browse/HIVE-1988>
Diffs
* http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java (1085623)
* http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java (1085623)
View Diff <https://reviews.apache.org/r/528/diff/>
Re: Review Request: HIVE-1988
Posted by Devaraj Das <dd...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/528/
-----------------------------------------------------------
(Updated 2011-03-29 10:26:38.374832)
Review request for hive.
Summary
-------
Fixes to some security issues discussed in HIVE-1988
This addresses bug HIVE-1988.
https://issues.apache.org/jira/browse/HIVE-1988
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 1085623
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java 1085623
http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java 1085623
Diff: https://reviews.apache.org/r/528/diff
Testing (updated)
-------
New unit test added and that passes. All unit tests passed.
Thanks,
Devaraj