You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/04/30 03:37:41 UTC
Review Request 33709: Cloned widget should show in widget layout and
widget browser
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33709/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-10856
https://issues.apache.org/jira/browse/AMBARI-10856
Repository: ambari
Description
-------
Cloned widget should appear in the layout and widget browser
This patch also addresses a regression where going to HDFS heatmap page throws an exception
widget browser only shows service tabs for services with enhanced widgets (HDFS, MapReduce2, YARN and HBase)
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 1ff75ec
ambari-web/app/controllers/main/service/info/summary.js 9223cc0
ambari-web/app/mixins/common/widgets/widget_mixin.js c9b2614
ambari-web/app/mixins/common/widgets/widget_section.js 8ba6fd5
Diff: https://reviews.apache.org/r/33709/diff/
Testing
-------
Tested manually and verified that unit tests passess.
Thanks,
Jaimin Jetly
Re: Review Request 33709: Cloned widget should show in widget layout
and widget browser
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33709/#review82090
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On April 30, 2015, 1:42 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33709/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 1:42 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-10856
> https://issues.apache.org/jira/browse/AMBARI-10856
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cloned widget should appear in the layout and widget browser
> This patch also addresses a regression where going to HDFS heatmap page throws an exception
> widget browser only shows service tabs for services with enhanced widgets (HDFS, MapReduce2, YARN and HBase)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 1ff75ec
> ambari-web/app/controllers/main/service/info/summary.js df49e8c
> ambari-web/app/mixins/common/widgets/widget_mixin.js c9b2614
>
> Diff: https://reviews.apache.org/r/33709/diff/
>
>
> Testing
> -------
>
> Tested manually and verified that unit tests passess.
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 33709: Cloned widget should show in widget layout
and widget browser
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33709/
-----------------------------------------------------------
(Updated April 30, 2015, 1:42 a.m.)
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-10856
https://issues.apache.org/jira/browse/AMBARI-10856
Repository: ambari
Description
-------
Cloned widget should appear in the layout and widget browser
This patch also addresses a regression where going to HDFS heatmap page throws an exception
widget browser only shows service tabs for services with enhanced widgets (HDFS, MapReduce2, YARN and HBase)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 1ff75ec
ambari-web/app/controllers/main/service/info/summary.js df49e8c
ambari-web/app/mixins/common/widgets/widget_mixin.js c9b2614
Diff: https://reviews.apache.org/r/33709/diff/
Testing
-------
Tested manually and verified that unit tests passess.
Thanks,
Jaimin Jetly