[GitHub] [zeppelin] alexott commented on a change in pull request #3711: [ZEPPELIN-4710]. Allow to inject application id into custom spark url

[GitBox <gi...@apache.org>]

alexott commented on a change in pull request #3711: [ZEPPELIN-4710]. Allow to inject application id into custom spark url
URL: https://github.com/apache/zeppelin/pull/3711#discussion_r401481087
 
 

 ##########
 File path: spark/spark-scala-parent/src/main/scala/org/apache/zeppelin/spark/BaseSparkScalaInterpreter.scala
 ##########
 @@ -237,6 +237,13 @@ abstract class BaseSparkScalaInterpreter(val conf: SparkConf,
       case None =>
     }
 
+    val webUiUrl = properties.getProperty("zeppelin.spark.uiWebUrl");
+    if (!StringUtils.isBlank(webUiUrl)) {
+      this.sparkUrl = webUiUrl.replace("{{applicationId}}", sc.applicationId);
+    } else {
+      useYarnProxyURLIfNeeded()
+    }
+
 
 Review comment:
   I would move this into a separate function to remove duplicates.
   Another issue - we need to make safe value from `sc.applicationId`, so we couldn't get any security problem...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services