You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/07/07 15:41:23 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6883: Minor: Consolidate display related traits
alamb opened a new pull request, #6883:
URL: https://github.com/apache/arrow-datafusion/pull/6883
# Which issue does this PR close?
Related to #1754
# Rationale for this change
I would like to move all physical plan into its own crate eventually, thus there can't be back dependencies to core
# What changes are included in this PR?
Move `ProjectSchemaDisplay` and `OutputOrderingDisplay` TO the display module with the other ExecutionPlan display code, most recently modified by @liurenjie1024 in https://github.com/apache/arrow-datafusion/pull/6726
# Are these changes tested?
existing CI
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6883: Minor: Consolidate display related traits
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6883:
URL: https://github.com/apache/arrow-datafusion/pull/6883#discussion_r1256027928
##########
datafusion/core/src/datasource/physical_plan/mod.rs:
##########
@@ -415,39 +418,6 @@ where
Ok(())
}
-/// A wrapper to customize partitioned file display
Review Comment:
This code is moved to `datafusion/core/src/physical_plan/display.rs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6883: Minor: Consolidate display related traits
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6883:
URL: https://github.com/apache/arrow-datafusion/pull/6883#discussion_r1256028416
##########
datafusion/core/src/physical_plan/streaming.rs:
##########
@@ -28,7 +28,7 @@ use datafusion_common::{DataFusionError, Result, Statistics};
use datafusion_physical_expr::{LexOrdering, PhysicalSortExpr};
use log::debug;
-use crate::datasource::physical_plan::{OutputOrderingDisplay, ProjectSchemaDisplay};
Review Comment:
I didn't want to have a depenency on `datasource` from `physical_plan`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6883: Minor: Consolidate display related traits
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6883:
URL: https://github.com/apache/arrow-datafusion/pull/6883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org