You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/05/25 19:57:00 UTC
[jira] [Comment Edited] (ARROW-7017) [C++] Refactor AddKernel to
support other operations and types
[ https://issues.apache.org/jira/browse/ARROW-7017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116221#comment-17116221 ]
Wes McKinney edited comment on ARROW-7017 at 5/25/20, 7:56 PM:
---------------------------------------------------------------
I think the path forward here is to refactor to utilize common implementations of inline single-value functions for both the LLVM IR and pre-compiled kernels. In other words, what is currently in the gandiva/precompiled directory would be moved to some place where we can arrange so that these implementations are translated to LLVM IR for use in Gandiva, while available as inline C/C++ functions for use in creating pre-compiled vectorized kernels. Having multiple implementations of the scalar "unit of work" does not seem desirable
Note that Gandiva-generated kernels should be able (with some glue) to be registered in the new general function registry in arrow/compute/registry.h
was (Author: wesmckinn):
I think the path forward here is to refactor to utilize common implementations of for both the LLVM IR and pre-compiled kernels. In other words, what is currently in the gandiva/precompiled directory would be moved to some place where we can arrange so that these implementations are translated to LLVM IR for use in Gandiva, while available as inline C/C++ functions for use in creating pre-compiled vectorized kernels. Having multiple implementations of the scalar "unit of work" does not seem desirable
> [C++] Refactor AddKernel to support other operations and types
> --------------------------------------------------------------
>
> Key: ARROW-7017
> URL: https://issues.apache.org/jira/browse/ARROW-7017
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Francois Saint-Jacques
> Assignee: Wes McKinney
> Priority: Major
> Labels: analytics
>
> * Should avoid using builders (and/or NULLs) since the output shape is known a compute time.
> * Should be refatored to support other operations, e.g. Substraction, Multiplication.
> * Should have a overflow, underflow detection mode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)