You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Devaraj Das (Created) (JIRA)" <ji...@apache.org> on 2012/02/17 02:32:00 UTC

[jira] [Created] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Protobuf RPC engine can be optimized to not do copying for the RPC request/response
-----------------------------------------------------------------------------------

                 Key: HADOOP-8084
                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
             Project: Hadoop Common
          Issue Type: Improvement
            Reporter: Devaraj Das
            Assignee: Devaraj Das




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Devaraj Das (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-8084:
--------------------------------

    Attachment: protobuf-no-copy.patch

Straightforward patch. This is relevant to mapreduce too.
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212371#comment-13212371 ] 

Hudson commented on HADOOP-8084:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1833 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1833/])
    HADOOP-8084. Updates ProtoBufRpc engine to not do an unnecessary copy for RPC request/response. Contributed by Devaraj Das. (Revision 1291602)

     Result = SUCCESS
ddas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1291602
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java

                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212410#comment-13212410 ] 

Mahadev konar commented on HADOOP-8084:
---------------------------------------

Check with Nicholas, he's been maintaining the PB branch.
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-8084:
-------------------------------------------

    Fix Version/s: 0.23.3

I have merged this to 0.23.
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0, 0.23.3
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-8084:
-----------------------------------

          Component/s: ipc
    Affects Version/s: 0.24.0
        Fix Version/s: 0.24.0
    
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8084:
--------------------------------

    Release Note:   (was: patch looks good, marking patch available so Hudson runs)

[oops, put comment in the wrong field.. duh]

patch looks good, marking patch available so Hudson runs
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212396#comment-13212396 ] 

Mahadev konar commented on HADOOP-8084:
---------------------------------------

Ddas, 
 Can you merge this to the PB branch? 
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212379#comment-13212379 ] 

Hudson commented on HADOOP-8084:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #1759 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1759/])
    HADOOP-8084. Updates ProtoBufRpc engine to not do an unnecessary copy for RPC request/response. Contributed by Devaraj Das. (Revision 1291602)

     Result = SUCCESS
ddas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1291602
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java

                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210130#comment-13210130 ] 

Aaron T. Myers commented on HADOOP-8084:
----------------------------------------

The patch makes sense to me. Have you done any benchmarks? Perhaps using the tool introduced in HADOOP-8070?
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Devaraj Das (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212399#comment-13212399 ] 

Devaraj Das commented on HADOOP-8084:
-------------------------------------

Is that branch (branch-0.23-PB) scheduled to be merged with 0.23? This issue is currently marked for 0.24. I am okay merging this fix with that branch but wanted to double-check... 
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Todd Lipcon (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-8084:
--------------------------------

    Release Note: patch looks good, marking patch available so Hudson runs
          Status: Patch Available  (was: Open)
    
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212319#comment-13212319 ] 

Hadoop QA commented on HADOOP-8084:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12514923/protobuf-no-copy.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/615//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/615//console

This message is automatically generated.
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213620#comment-13213620 ] 

Hudson commented on HADOOP-8084:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #998 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/998/])
    HADOOP-8084. Updates ProtoBufRpc engine to not do an unnecessary copy for RPC request/response. Contributed by Devaraj Das. (Revision 1291602)

     Result = SUCCESS
ddas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1291602
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java

                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212851#comment-13212851 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-8084:
------------------------------------------------

Hi Devaraj and Mahadev,

I will merge this to 0.23-PB.  Thanks.
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212398#comment-13212398 ] 

Hudson commented on HADOOP-8084:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1770 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1770/])
    HADOOP-8084. Updates ProtoBufRpc engine to not do an unnecessary copy for RPC request/response. Contributed by Devaraj Das. (Revision 1291602)

     Result = ABORTED
ddas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1291602
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java

                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Devaraj Das (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210426#comment-13210426 ] 

Devaraj Das commented on HADOOP-8084:
-------------------------------------

No I haven't done benchmarks. But it seemed to make sense to avoid a copy if it could be avoided.
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Devaraj Das (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-8084:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks Aaron and Todd for the reviews.
                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8084) Protobuf RPC engine can be optimized to not do copying for the RPC request/response

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212655#comment-13212655 ] 

Hudson commented on HADOOP-8084:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #962 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/962/])
    HADOOP-8084. Updates ProtoBufRpc engine to not do an unnecessary copy for RPC request/response. Contributed by Devaraj Das. (Revision 1291602)

     Result = FAILURE
ddas : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1291602
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java

                
> Protobuf RPC engine can be optimized to not do copying for the RPC request/response
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-8084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8084
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.24.0
>
>         Attachments: protobuf-no-copy.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira