[jira] [Resolved] (DERBY-5683) BaseJDBCTestCase.getDatabaseProperty() should close resources before returning

["Knut Anders Hatlen (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen resolved DERBY-5683.
---------------------------------------

          Resolution: Fixed
       Fix Version/s: 10.9.0.0
    Issue & fix info:   (was: Patch Available)

Thanks for reviewing the patch, Dag.

I think I prefer to keep the name "closeStatement", as the logical operation of the method is to close the statement. Removing it from the "statements" list is just internal bookkeeping. Also, the "closeStatement" method is the inverse of the "createStatement", "prepareStatement" and "prepareCall" methods in BaseJDBCTestCase, which don't have the "remembering/adding" aspect reflected in their names.

Committed revision 1310413.
                
> BaseJDBCTestCase.getDatabaseProperty() should close resources before returning
> ------------------------------------------------------------------------------
>
>                 Key: DERBY-5683
>                 URL: https://issues.apache.org/jira/browse/DERBY-5683
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.9.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>             Fix For: 10.9.0.0
>
>         Attachments: d5683-1a-close-and-forget.diff
>
>
> BaseJDBCTestCase.getDatabaseProperty() creates a PreparedStatement and a ResultSet that are not closed before the method returns. If a test case calls getDatabaseProperty() many times, the open statements may have a big memory footprint.
> This can be seen for example by running jdbcapi.AuthenticationTest with -Xmx64. It will fail with an OutOfMemoryError when testNoCollisionsWithConfigurableHash() runs in client/server mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira