[GitHub] [spark] grundprinzip commented on a diff in pull request #38086: [SPARK-40539][CONNECT] Initial DataFrame Read API parity for Spark Connect

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #38086:
URL: https://github.com/apache/spark/pull/38086#discussion_r990797491


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -65,11 +65,25 @@ message SQL {
 message Read {
   oneof read_type {
     NamedTable named_table = 1;
+    FileDataSource file_data_source = 2;
   }
 
   message NamedTable {
     repeated string parts = 1;
   }
+
+  message FileDataSource {
+    repeated string path = 1;
+    string format = 2;
+    string schema = 3;
+    repeated DataSourceOptionPair options = 4;
+  }
+
+  message DataSourceOptionPair {
+    // Option key is case insensitive.
+    string option_key = 1;
+    string option_value = 2;

Review Comment:
   Sorry for the late reply, isn't the option_value actually more a literal?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org