You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wenwenxiong <gi...@git.apache.org> on 2015/12/02 07:44:44 UTC
[GitHub] cloudstack pull request: Update JuniperSrxResource.java
GitHub user wenwenxiong opened a pull request:
https://github.com/apache/cloudstack/pull/1148
Update JuniperSrxResource.java
fix "action" will not relace in xml
if type.equals(SecurityPolicyType.SECURITYPOLICY_EGRESS_DEFAULT)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wenwenxiong/cloudstack patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1148
----
commit 61985c482e34ceb4df0598b643343e64a94b733d
Author: wenwenxiong <xi...@163.com>
Date: 2015-12-02T06:41:19Z
Update JuniperSrxResource.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update JuniperSrxResource.java
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-162344831
@wenwenxiong can you add tests and or test data to this? any combination of
- unit tests
- marvin tests
- test procedure
thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update JuniperSrxResource.java
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-222390201
### ACS CI BVT Run
**Sumarry:**
Build Number 84
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update JuniperSrxResource.java
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-216205836
LGTM, @wenwenxiong can you rebase against latest master and share state of your PR, thanks
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update JuniperSrxResource.java
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1148#discussion_r50638624
--- Diff: plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java ---
@@ -2841,8 +2841,9 @@ private boolean manageSecurityPolicy(SecurityPolicyType type, SrxCommand command
action = "<permit></permit>";
}
- xml = replaceXmlValue(xml, "action", action);
+
}
+ xml = replaceXmlValue(xml, "action", action);
--- End diff --
Why did you put it out of "if-then-else"?
Shouldn't it only be executed only if "!type.equals(SecurityPolicyType.SECURITYPOLICY_EGRESS_DEFAULT)"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Update JuniperSrxResource.java
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-174321124
Hi @wenwenxiong, could you make a Jira for this PR?
Did you make any test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---