You are viewing a plain text version of this content. The canonical link for it is here.
Posted to legal-discuss@apache.org by "Kristian Rosenvold (JIRA)" <ji...@apache.org> on 2013/01/16 08:16:12 UTC
[jira] [Created] (LEGAL-156) Can we accept pull requests from
github ?
Kristian Rosenvold created LEGAL-156:
----------------------------------------
Summary: Can we accept pull requests from github ?
Key: LEGAL-156
URL: https://issues.apache.org/jira/browse/LEGAL-156
Project: Legal Discuss
Issue Type: Question
Reporter: Kristian Rosenvold
In maven, we generally require that all external submissions have JIRA issues. With svn we would normally have patches attached to the jira issue, which would link a submission to the submitter.
With pull requests coming in from github, we receive a "submission" that is tagged with author name and email and an external reference to the diff (a link to the commit on github). This pull request is sent to ASF mailing lists and would IMO serve as a record of submission. Given that the author information in the commit seems valid, can we accept such a pull request directly ? (to this moment we still require that authors add patches to jira as well)
(It would look to me like the only thing missing is that we have the process picking up the pull requests actually attach the diff to the mail too, but heck IANAL).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org
Re: [jira] [Created] (LEGAL-156) Can we accept pull requests from
github ?
Posted by Diana Andrews <no...@gmail.com>.
Yes,you are allowed to fulfill that request
as requested in this reply(JIRA).
Signed,
Diana j. Andrews
On Jan 15, 2013 11:16 PM, "Kristian Rosenvold (JIRA)" <ji...@apache.org>
wrote:
> Kristian Rosenvold created LEGAL-156:
> ----------------------------------------
>
> Summary: Can we accept pull requests from github ?
> Key: LEGAL-156
> URL: https://issues.apache.org/jira/browse/LEGAL-156
> Project: Legal Discuss
> Issue Type: Question
> Reporter: Kristian Rosenvold
>
>
> In maven, we generally require that all external submissions have JIRA
> issues. With svn we would normally have patches attached to the jira issue,
> which would link a submission to the submitter.
>
> With pull requests coming in from github, we receive a "submission" that
> is tagged with author name and email and an external reference to the diff
> (a link to the commit on github). This pull request is sent to ASF mailing
> lists and would IMO serve as a record of submission. Given that the author
> information in the commit seems valid, can we accept such a pull request
> directly ? (to this moment we still require that authors add patches to
> jira as well)
>
> (It would look to me like the only thing missing is that we have the
> process picking up the pull requests actually attach the diff to the mail
> too, but heck IANAL).
>
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
> For additional commands, e-mail: legal-discuss-help@apache.org
>
>