You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "sakulali (via GitHub)" <gi...@apache.org> on 2023/03/31 12:19:18 UTC
[GitHub] [apisix-helm-chart] sakulali opened a new pull request, #524: feat: add admission configuration for APISIX Ingress controllerAdmission
sakulali opened a new pull request, #524:
URL: https://github.com/apache/apisix-helm-chart/pull/524
@tao12345666333 Excuse me, when i choose `admission.enabled: true` in `values.yaml` , occur some mistakes as shown below, i found [https://github.com/apache/apisix-ingress-controller/pull/1355](url) seems to resolve the mistakes? Thanks!
1. k8s setup with kind, ubuntu 20.04
2. `helm install apisix apisix/apisix --create-namespace --namespace ingress-apisix --set admin.allow.ipList="" --set gateway.type=NodePort`
3. `helm install apisix-ingress-controller --namespace ingress-apisix --set config.logLevel=debug`
4. `kubectl run httpbin --image kennethreitz/httpbin --port 80 && kubectl expose pod httpbin --port 80`
5. `kubectl apply -f httpbin-ingress.yaml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] AlinsRan commented on a diff in pull request #524: feat: add admission configuration for APISIX Ingress controller
Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan commented on code in PR #524:
URL: https://github.com/apache/apisix-helm-chart/pull/524#discussion_r1155467860
##########
charts/apisix-ingress-controller/templates/webhook-configuration.yaml:
##########
@@ -0,0 +1,137 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+{{/*
+ If the user does not have cert-manager and is not providing a secret with the certificates, the chart needs to generate the secret
+*/}}
+{{- $webhookSvc := .Values.admission.webhookSvc }}
+{{- $nameSvc := (printf "%s.%s" $webhookSvc .Release.Namespace) }}
+{{- $ca := genCA "ingress-apisix-ca" 365 }}
+{{- $cert := genSignedCert (printf "%s.svc" $nameSvc) nil (list $webhookSvc (printf "%s.svc" $nameSvc) (printf "%s.pod" $nameSvc) (printf "%s.svc.cluster.local" $nameSvc) (printf "%s.pod.cluster.local" $nameSvc)) 365 $ca }}
+
+---
+{{- if .Values.admission.enabled }}
+apiVersion: v1
+kind: Secret
+metadata:
+ name: webhook-certs
+ namespace: {{ .Release.Namespace }}
+type: Opaque
+data:
+ cert.pem: {{ $cert.Cert | b64enc }}
+ key.pem: {{ $cert.Key | b64enc }}
+{{- end }}
+
+---
+{{- if .Values.admission.enabled }}
+apiVersion: admissionregistration.k8s.io/v1
+kind: ValidatingWebhookConfiguration
+metadata:
+ name: apisix-validation-webhooks
Review Comment:
This is a cluster level resource.
Multiple controllers may be installed in a cluster, requiring `{{. Release. Namespace}}` for isolation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] AlinsRan commented on pull request #524: feat: add admission configuration for APISIX Ingress controller
Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan commented on PR #524:
URL: https://github.com/apache/apisix-helm-chart/pull/524#issuecomment-1653714057
@leowmjw Need to wait for release apisix-ingress-controller:1.7.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] AlinsRan commented on pull request #524: feat: add admission configuration for APISIX Ingress controller
Posted by "AlinsRan (via GitHub)" <gi...@apache.org>.
AlinsRan commented on PR #524:
URL: https://github.com/apache/apisix-helm-chart/pull/524#issuecomment-1493641699
Webhook is not yet available, we need to wait for https://github.com/apache/apisix-ingress-controller/pull/1355 merge and release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add admission configuration for APISIX Ingress controller [apisix-helm-chart]
Posted by "pcjun97 (via GitHub)" <gi...@apache.org>.
pcjun97 commented on PR #524:
URL: https://github.com/apache/apisix-helm-chart/pull/524#issuecomment-2002752681
Hi @AlinsRan any updates on this feature? The latest version is now 1.8.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #524: feat: add admission configuration for APISIX Ingress controller
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #524:
URL: https://github.com/apache/apisix-helm-chart/pull/524#issuecomment-1492022927
When you install APISIX using Helm, please use this command. It will deploy APISIX and APISIX Ingress controller and add some configurations.
```
helm install apisix apisix/apisix --set ingress-controller.enabled=true --set ingress-controller.config.apisix.serviceNamespace=apisix --namespace apisix --create-namespace --set ingress-controller.config.apisix.serviceName=apisix-admin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] leowmjw commented on pull request #524: feat: add admission configuration for APISIX Ingress controller
Posted by "leowmjw (via GitHub)" <gi...@apache.org>.
leowmjw commented on PR #524:
URL: https://github.com/apache/apisix-helm-chart/pull/524#issuecomment-1653222688
@sakulali @AlinsRan Now with webhook available; can this feature be completed? It will be useful for my use case it think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] sakulali commented on pull request #524: feat: add admission configuration for APISIX Ingress controller
Posted by "sakulali (via GitHub)" <gi...@apache.org>.
sakulali commented on PR #524:
URL: https://github.com/apache/apisix-helm-chart/pull/524#issuecomment-1499252330
> Webhook is not yet available, we need to wait for [apache/apisix-ingress-controller#1355](https://github.com/apache/apisix-ingress-controller/pull/1355) merge and release
Sorry for delay, so glad to wait for that feature release, i will sync with that pr if necessary, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org