You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Omar Carvajal (Created) (JIRA)" <ji...@apache.org> on 2012/02/09 23:50:57 UTC
[jira] [Created] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Allow all of the properties of the Messages services to be accessed
-------------------------------------------------------------------
Key: TAP5-1843
URL: https://issues.apache.org/jira/browse/TAP5-1843
Project: Tapestry 5
Issue Type: New Feature
Affects Versions: 5.3.2, 5.2.6
Reporter: Omar Carvajal
Priority: Minor
There are cases in which the properties Map of the Messages service should be public.
For example, the message catalog needs to be serialized and sent back to the browser.
I am including a patch that implements the "getAll" method in the Messages service.
It applies correctly on Tapestry 5.2.6 and 5.3.2.
Here is a discussion of this in the mailing list:
http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Omar Carvajal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Omar Carvajal updated TAP5-1843:
--------------------------------
Attachment: messagesGetKeys.patch
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch, messagesGetKeys.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Dragan Sahpaski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205522#comment-13205522 ]
Dragan Sahpaski commented on TAP5-1843:
---------------------------------------
Hi Omar,
I saw the commit right away just didn't get the time to comment.
My comment would have been the same as Thiago's.
I don't think copy constructor is also the way to go.
Maybe Iterator or something like that that is immutable. Or maybe it's best if you look at other existing public interfaces and see how Map's values (in the implementation class) are exposed for reading there. It would be easier to get your patch accepted if it consistent with the way things are previously done in Tapestry.
Cheers,
Dragan
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Thiago H. de Paula Figueiredo (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205425#comment-13205425 ]
Thiago H. de Paula Figueiredo commented on TAP5-1843:
-----------------------------------------------------
Hi, Omar!
I don't think your patch will be accepted because it returns the map itself. This is a break of encapsulation and information hiding. Instead, we could have a method that returns a collection of all the keys.
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Omar Carvajal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Omar Carvajal updated TAP5-1843:
--------------------------------
Attachment: messagesGetAll.patch
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Omar Carvajal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205491#comment-13205491 ]
Omar Carvajal commented on TAP5-1843:
-------------------------------------
Hey Thiago,
Thanks for your feedback. You are correct, I wasn't thinking with the fact that Map isn't immutable.
Couldn't I just use a copy constructor then to return a clone of the map?
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Omar Carvajal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Omar Carvajal updated TAP5-1843:
--------------------------------
Attachment: messagesGetKeys.patch
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch, messagesGetKeys.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Dragan Sahpaski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205522#comment-13205522 ]
Dragan Sahpaski commented on TAP5-1843:
---------------------------------------
Hi Omar,
I saw the commit right away just didn't get the time to comment.
My comment would have been the same as Thiago's.
I don't think copy constructor is also the way to go.
Maybe Iterator or something like that that is immutable. Or maybe it's best if you look at other existing public interfaces and see how Map's values (in the implementation class) are exposed for reading there. It would be easier to get your patch accepted if it consistent with the way things are previously done in Tapestry.
Cheers,
Dragan
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Omar Carvajal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205531#comment-13205531 ]
Omar Carvajal commented on TAP5-1843:
-------------------------------------
Hey Dragan,
I see what you mean.
I created a new patch that implements it this way "getKeys", using an Iterator.
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch, messagesGetKeys.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Omar Carvajal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205491#comment-13205491 ]
Omar Carvajal commented on TAP5-1843:
-------------------------------------
Hey Thiago,
Thanks for your feedback. You are correct, I wasn't thinking with the fact that Map isn't immutable.
Couldn't I just use a copy constructor then to return a clone of the map?
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Omar Carvajal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Omar Carvajal updated TAP5-1843:
--------------------------------
Attachment: messagesGetAll.patch
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Omar Carvajal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205531#comment-13205531 ]
Omar Carvajal commented on TAP5-1843:
-------------------------------------
Hey Dragan,
I see what you mean.
I created a new patch that implements it this way "getKeys", using an Iterator.
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch, messagesGetKeys.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1843) Allow all of the properties of the
Messages services to be accessed
Posted by "Thiago H. de Paula Figueiredo (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205425#comment-13205425 ]
Thiago H. de Paula Figueiredo commented on TAP5-1843:
-----------------------------------------------------
Hi, Omar!
I don't think your patch will be accepted because it returns the map itself. This is a break of encapsulation and information hiding. Instead, we could have a method that returns a collection of all the keys.
> Allow all of the properties of the Messages services to be accessed
> -------------------------------------------------------------------
>
> Key: TAP5-1843
> URL: https://issues.apache.org/jira/browse/TAP5-1843
> Project: Tapestry 5
> Issue Type: New Feature
> Affects Versions: 5.3.2, 5.2.6
> Reporter: Omar Carvajal
> Priority: Minor
> Attachments: messagesGetAll.patch
>
>
> There are cases in which the properties Map of the Messages service should be public.
> For example, the message catalog needs to be serialized and sent back to the browser.
> I am including a patch that implements the "getAll" method in the Messages service.
> It applies correctly on Tapestry 5.2.6 and 5.3.2.
> Here is a discussion of this in the mailing list:
> http://tapestry.1045711.n5.nabble.com/Serialize-Messages-td5463756.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira