You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/08/18 04:14:39 UTC
[GitHub] [netbeans] eirikbakke opened a new pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
eirikbakke opened a new pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115
In a previous PR ( https://github.com/apache/netbeans/pull/2967 ), the tab components in the NetBeans window system were redesigned and modernized for the Windows LAF. This PR ports related tabcontrol improvements back into FlatLAF, and proposes a similar tab style for FlatLAF. See the attached screenshots.
The proposed style, compared to the current FlatLAF style, makes the selected tab look like an actual "tab" with an actual rectangular border around it, while keeping the much simpler "separators only" look for unselected tabs. The proposed style also tightens up vertical space significantly, like in other LAFs. See the attached screenshots. The new tab controls work well on all HiDPI scaling levels, and on all platforms (Windows, Linux, MacOS).
Advantages of the proposed tabcontrol style:
* Other applications that have tabs as part of their window system still tend to render at least the active window system tab as an actual "tabs", e.g. Chrome, Excel, Photoshop, Unity.
* Personally, I find it hard to orient my eyes around the old FlatLAF tab style; the drawn selected tab seems to fix this. (Hard to explain in a fully objective way!)
* The tab content areas (contents of editor, projects pane, navigator pane etc.) has borders around them, so it is logical that the border continues around the tab that is associated with them.
* Conserve vertical space. Modern monitors have tended to become wider but not taller. With e.g. 2x HiDPI scaling (as on all MacBooks), there may actually be _fewer_ logical pixels available in the vertical direction than on older laptop screens.
This PR also removes an extraneous border around the editor area, and introduces a little bit of extra space in the toolbar area.
I've been using FlatLAF as the default LAF on Linux for my NetBeans Platform application. It handles HiDPI scaling very well, and it's getting really solid--thanks to @DevCharly for all his work on it!
### Before/after screenshots, FlatLAF Light:
### Before/after screenshots, FlatLAF Dark:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-1021288878
I do like having the tab on the same 3d level as the editor. Its more intuitive and makes it clearer that the tab belongs to the active view. Having a border between tab and view only causes second guessing. +1 from me too. Would be great if we could get this finished for NB 14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-918505323
OK, good, that's what I thought. Yes, it'll be best to get @DevCharly's opinion here. No hurry--I don't mind this PR baking for a while.
One new thought: Perhaps the difference between JTabbedPane and the window system tabs is actually a good thing? Especially in the case of the Output pane--it was always awkward to put one set of tabs inside another one. On the Aqua LAF, the tab styles are intentionally different:
There's still the dialog boxes, but I feel like the old FlatLAF style works well in those, even if the window system tabs in the main window follow the more standard bordered-tab appearance.
Anyway, will await input...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-918476964
> I assume you mean the difference between the window system tabs and the regular JTabbedPane? (E.g. the sub-tabs in the "Output" pane?)
@eirikbakke yes, this. Also across other windows in the IDE. I like the visual consistency. I also understand the concerns. But I'm interested in whether @DevCharly has an idea on how to address the concerns without losing the consistency in the design?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
On the inconsistency between regular tabs and window system tabs, I also considered the option of changing the regular tabs. But that would require a change in the FlatLAF library, which is outside the NetBeans codebase.
It would be interesting to gather screenshots from tab styles in different apps. I don't have the latest MacOS or Ubuntu available, but here are a few:
Windows:
Photoshop:
Chrome:
Unity:
IntelliJ:
Microsoft Edge:
<img width="639" alt="TabEdge" src="https://user-images.githubusercontent.com/886243/129924491-8bf9b9c1-c86f-408a-8c1d-c3e209a81073.png">
Visual Studio 2022 Preview (blurry screenshot from a YouTube video...):
I think the existing FlatLAF style looks most like IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-900925192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#discussion_r791821935
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java
##########
@@ -73,8 +75,10 @@
VIEW_TAB_DISPLAYER_UI, "org.netbeans.swing.laf.flatlaf.ui.FlatViewTabDisplayerUI", // NOI18N
SLIDING_BUTTON_UI, "org.netbeans.swing.laf.flatlaf.ui.FlatSlidingButtonUI", // NOI18N
- EDITOR_TABSCOMPONENT_BORDER, DPISafeBorder.matte(1, 1, 1, 1, editorContentBorderColor),
- EDITOR_TOOLBAR_BORDER, DPISafeBorder.matte(0, 0, 1, 0, editorContentBorderColor),
+ EDITOR_TABSCOMPONENT_BORDER, BorderFactory.createEmptyBorder(),
+ EDITOR_TOOLBAR_BORDER, new CompoundBorder(
+ DPISafeBorder.matte(0, 0, 1, 0, editorContentBorderColor),
+ BorderFactory.createEmptyBorder(1, 0, 1, 0)),
Review comment:
nitpick: All other key/values use a single line. I think it would be easier to read to do the same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981791864
Agreed! My objection to your initial proposal was mostly based on the addition of borders and a gradient - ie. no longer being flat. Using a revised flat background colour, and moving the highlight (not always blue!) above, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
On the inconsistency between regular tabs and window system tabs, I also considered the option of changing the regular tabs. But that would require a change in the FlatLAF library, which is outside the NetBeans codebase.
It would be interesting to gather screenshots from tab styles in different apps. I don't have the latest MacOS or Ubuntu available, but here are a few:
Windows:
Photoshop:
Chrome:
Unity:
IntelliJ:
Microsoft Edge:
<img width="639" alt="TabEdge" src="https://user-images.githubusercontent.com/886243/129924491-8bf9b9c1-c86f-408a-8c1d-c3e209a81073.png">
Visual Studio 2022 Preview (blurry screenshot from a YouTube video...):
Eclipse:
Maya:
Blender:
I think the existing FlatLAF style looks most like IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-900896710
Cool, thx @eirikbakke. I hope I can identify my current opened tab better with this approach, because I use colorful tabs and there it is hard to find the current tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
On the inconsistency between regular tabs and window system tabs, I also considered the option of changing the regular tabs. But that would require a change in the FlatLAF library, which is outside the NetBeans codebase.
It would be interesting to gather screenshots from tab styles in different apps. I don't have the latest MacOS or Ubuntu available, but here are a few.
Windows:
Photoshop:
Chrome:
Unity:
IntelliJ:
I think the FlatLAF style looks most like IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981778559
Now there's a new JetBrains IDE called Fleet, and even JetBrains now puts the tab selection highlight at the top rather than at the bottom of the tab:
I think the bottom of the tab really needs to have the same color as the background of the pane below; that's what makes it look like a tab. The blue tab selection highlight looks good, but needs to be on the outer edge of the tab to avoid disrupting this continuity. See e.g. Fleet, Unity, Excel, PowerBI, and Thunderbird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901099895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-900896710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981791864
Agreed! My objection to your initial proposal were mostly based on the addition of borders and a gradient - ie. no longer being flat. Using a revised flat background colour, and moving the highlight (not always blue!) above, makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-984279818
The spacing around the filename is an interesting design question. In the old Windows and Aqua LAFs, the tabs were designed to take up the absolute minimum amount of vertical space, with just one pixel of spacing from the icon to the top/bottom borders:
The current FlatLAF style uses more space, while the proposal in this PR is a bit of a compromise between the two (here showing screenshots with 2x HiDPI/Retina scaling):
In the horizontal direction, the changes in this PR are smaller, mainly to make sure the "X" is closer to the text it is associated with rather than the border before the next tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981820591
@Chris2011 With any one of those options activated, you would see the old editor tab style for now. I think they actually use a different tab component altogether. If we end up agreeing on an acceptable patch for the common case, I can later make a patch to extend it to the special tab options as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901112892
I'd be happy to make it into an option in the GUI, too.
I think FlatLAF fills three different roles in the NetBeans world--(1) as an "alternative" LAF that has its own distinct look and does not try to look like native apps, (2) as a "dark" LAF and (3) as the LAF that has best support for HiDPI screens on Linux. For role (1), the old look makes sense, but for roles (2) and (3), there may be people who actually want the IDE to look like a standard desktop app, but with dark mode or Linux HiDPI support. These different roles might justify having an explicit option that the user can select.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-918340193
> I don't like this change - it's inconsistent with the standard FlatLaf tab look, and across the different tab positions.
@neilcsmith-net Actually, for the future discussion--could you clarify what you meant here? I assume you mean the difference between the window system tabs and the regular JTabbedPane? (E.g. the sub-tabs in the "Output" pane?)
Or are you referring to the difference between the "view" tabs ("Projects/Files/Services") and the "editor" tabs? (These differences are more minor, but intentional, and were arrived at after a lot of experimentation.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
On the inconsistency between regular tabs and window system tabs, I also considered the option of changing the regular tabs. But that would require a change in the FlatLAF library, which is outside the NetBeans codebase.
It would be interesting to gather screenshots from tab styles in different apps. I don't have the latest MacOS or Ubuntu available, but here are a few:
Windows:
Photoshop:
Chrome:
Unity:
IntelliJ:
I think the existing FlatLAF style looks most like IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
On the inconsistency between regular tabs and window system tabs, I also considered the option of changing the regular tabs. But that would require a change in the FlatLAF library, which is outside the NetBeans codebase.
It would be interesting to gather screenshots from tab styles in different apps. I don't have the latest MacOS or Ubuntu available, but here are a few:
Windows:
Photoshop:
Chrome:
Unity:
IntelliJ:
I think the FlatLAF style looks most like IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
On the inconsistency between regular tabs and window system tabs, I also considered the option of changing the regular tabs. But that would require a change in the FlatLAF library, which is outside the NetBeans codebase.
It would be interesting to gather screenshots from tab styles in different apps. I don't have the latest MacOS or Ubuntu available, but here are a few:
Windows:
Photoshop:
Chrome:
Unity:
IntelliJ:
Microsoft Edge:
<img width="639" alt="TabEdge" src="https://user-images.githubusercontent.com/886243/129924491-8bf9b9c1-c86f-408a-8c1d-c3e209a81073.png">
Visual Studio 2022 Preview (blurry screenshot from a YouTube video...):
Eclipse:
Maya:
Blender:
Tableau:
PowerBI:
Excel:
Thunderbird:
I think the existing FlatLAF style looks most like IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981879142
@eirikbakke I tested your change and I like the proposed change to borders.
Space around filename seems too small but maybe I'm not used to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901136552
I think the usability issues (which I understand) and the 3 roles can still be met without making tabs look inconsistent across the UI. Hence requesting @DevCharly thoughts on that point. An option if we have to, but good not to have to!
As for "look like a standard desktop app", and given point (3), most of the standard apps on Ubuntu have a similar flat tab look. As does new macOS I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-1021325122
Would still be good to have a review from @DevCharly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-1021288878
I do like having the tab on the same 3d level as the editor. Its more intuitive and makes it clearer that the tab belongs to the active view. Having a border between tab and view only causes second guessing. +1 from me too. Would be great if we could get this finished for NB 14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#discussion_r791821935
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatLFCustoms.java
##########
@@ -73,8 +75,10 @@
VIEW_TAB_DISPLAYER_UI, "org.netbeans.swing.laf.flatlaf.ui.FlatViewTabDisplayerUI", // NOI18N
SLIDING_BUTTON_UI, "org.netbeans.swing.laf.flatlaf.ui.FlatSlidingButtonUI", // NOI18N
- EDITOR_TABSCOMPONENT_BORDER, DPISafeBorder.matte(1, 1, 1, 1, editorContentBorderColor),
- EDITOR_TOOLBAR_BORDER, DPISafeBorder.matte(0, 0, 1, 0, editorContentBorderColor),
+ EDITOR_TABSCOMPONENT_BORDER, BorderFactory.createEmptyBorder(),
+ EDITOR_TOOLBAR_BORDER, new CompoundBorder(
+ DPISafeBorder.matte(0, 0, 1, 0, editorContentBorderColor),
+ BorderFactory.createEmptyBorder(1, 0, 1, 0)),
Review comment:
nitpick: All other key/values use a single line. I think it would be easier to read to do the same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981778559
Now there's a new JetBrains IDE called Fleet, and even JetBrains now puts the tab selection highlight at the top rather than at the bottom of the tab:
I think the bottom of the tab really needs to have the same color as the background of the pane below; that's what makes it look like a tab. The blue tab selection highlight looks good, but needs to be on the outer edge of the tab to avoid disrupting the background color continuity. See e.g. Fleet, Unity, Excel, PowerBI, and Thunderbird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981778559
Now there's a new JetBrains IDE called Fleet, and even JetBrains now puts the tab selection highlight at the top rather than at the bottom of the tab:
I think the bottom of the tab really needs to have the same color as the background of the pane below; that's what makes it look like a tab. The blue tab selection highlight looks good, but needs to be on the outer edge of the tab to avoid disrupting the background color continuity. See e.g. Fleet, Unity, Excel, PowerBI, and Thunderbird.
(This comment is about window system tabs specifically. Per my previous comment, I still think it's a good idea to use the simplified FlatLAF tabs elsewhere in the UI, like in the Output pane, where having two different styles avoids the clutter of nested tab components. It's like having two different heading levels in a document.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981813195
I hadn't heard your objection about gradients before! There's a reason for the gradients that I hadn't explained before.
The problem is to make the relationship between the tab and the editor visually clear, as well as clearly showing which tab is selected. Having mocked up various different styles, I came to a couple of conflusions:
1) The background color of the bottom of the tab card needs to connect with the background color of the pane below (as mentioned before). And...
2) The background color of the selected tab needs to be brighter than the unselected tabs.
The problem is that the editor toolbar is the same brightness as the unselected tab background color. Changing the background colors of the editor toolbar or the draggable spaces between the TopComponents did not look good, in part because there are three levels of surfaces involved (application toolbar and unselected tab area, the editor toolbar, and the editor). The solution was to put a gradient on the selected tab, so the top could be made brighter and the tab would stand out.
As for the borders, these are actually _more_ consistent with the rest of the window than the previous style, because there are already borders around each TopComponent. If there are borders around each TopComponent, having them continue around the tab card looks good:
If we really wanted to get rid of borders, we'd need to remove them from the space between the TopComponents as well. (See the Unity screenshot for an example of that. Visual Studio 2022, on the other hand, keeps the borders.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981802993
How will this work for colored tabs and multi tabs? Just to leave this information here. Also we have this option to show the file path below the tabs and also the editor toolbar:
<img width="326" alt="image" src="https://user-images.githubusercontent.com/795658/143905933-7b7735d6-3a09-4226-8ab8-5c760cc946a4.png">
I really like when the tab is part of the editor that looks very good, I just wanted to get the attention for the other cases that we already have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-900925192
I don't like this change - it's inconsistent with the standard FlatLaf tab look, and across the different tab positions. (I'd also probably revert this in my own platform applications).
That's not to say some improvements to visibility of active tabs and reducing vertical space aren't a good idea. But prefer @DevCharly look at how this works consistently across FlatLaf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
On the inconsistency between regular tabs and window system tabs, I also considered the option of changing the regular tabs. But that would require a change in the FlatLAF library, which is outside the NetBeans codebase.
It would be interesting to gather screenshots from tab styles in different apps. I don't have the latest MacOS or Ubuntu available, but here are a few:
Windows:
Photoshop:
Chrome:
Unity:
IntelliJ:
Microsoft Edge:
<img width="639" alt="TabEdge" src="https://user-images.githubusercontent.com/886243/129924491-8bf9b9c1-c86f-408a-8c1d-c3e209a81073.png">
Visual Studio 2022 Preview (blurry screenshot from a YouTube video...):
Eclipse:
Maya:
Blender:
Tableau:
PowerBI:
I think the existing FlatLAF style looks most like IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901162270
On the inconsistency between regular tabs and window system tabs, I also considered the option of changing the regular tabs. But that would require a change in the FlatLAF library, which is outside the NetBeans codebase.
It would be interesting to gather screenshots from tab styles in different apps. I don't have the latest MacOS or Ubuntu available, but here are a few:
Windows:
Photoshop:
Chrome:
Unity:
IntelliJ:
Microsoft Edge:
<img width="639" alt="TabEdge" src="https://user-images.githubusercontent.com/886243/129924491-8bf9b9c1-c86f-408a-8c1d-c3e209a81073.png">
Visual Studio 2022 Preview (blurry screenshot from a YouTube video...):
Eclipse:
Maya:
Blender:
Tableau:
PowerBI:
Excel:
I think the existing FlatLAF style looks most like IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901099895
The "controversial" changes are all controlled by the settings in FlatDarkLaf.properties/FlatLightLaf.properties, so it's easy to restore the old look, or experiment with new variations. If preferred, I could modify this PR to keep the old look, but just add the new internal configuration options (+other smaller improvements) for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-901102975
The thing is, some wants the new, like me some not. If this is the thing, we need to change it via options and I prefer that to make this via Tools -> Options -> Appearance -> FlatLaf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-900928802
Could this be behind an option? @eirikbakke
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke edited a comment on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke edited a comment on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-981778559
Now there's a new JetBrains IDE called Fleet, and even JetBrains now puts the tab selection highlight at the top rather than at the bottom of the tab:
I think the bottom of the tab really needs to have the same color as the background of the pane below; that's what makes it look like a tab. The blue tab selection highlight looks good, but needs to be on the outer edge of the tab to avoid disrupting the background color continuity. See e.g. Fleet, Unity, Excel, PowerBI, and Thunderbird.
(This comment is about window system tabs specifically. Per my previous comment, I still think it's a good idea to use the simplified FlatLAF tabs elsewhere in the UI, like in the Output pane, where having two different styles avoids the clutter of nested tab components. It's like having two different heading levels in a document, with the outer level heading having a bigger and bolder font than the inner level headings.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3115: [NETBEANS-5928] Proposed improvements to FlatLAF tab components+borders/margins
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3115:
URL: https://github.com/apache/netbeans/pull/3115#issuecomment-1021325122
Would still be good to have a review from @DevCharly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists