You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/22 19:59:00 UTC
[GitHub] [incubator-mxnet] anirudhacharya commented on a change in pull
request #16416: Dgl ops 2
anirudhacharya commented on a change in pull request #16416: Dgl ops 2
URL: https://github.com/apache/incubator-mxnet/pull/16416#discussion_r337720563
##########
File path: tests/nightly/test_large_array.py
##########
@@ -1351,6 +1407,48 @@ def check_tan():
expected_output = [-.577, -1, 0, 1, .577]
assert_correctness_of_trigonometric_ops(y, expected_output)
+ def check_arcsinh():
+ x = create_input_for_trigonometric_ops([-np.pi/2, -np.pi/4, 0, np.pi/4, np.pi/2])
+ y = nd.arcsinh(x)
+ # expected ouput for indices=(0, 1, -3, -2, -1) after applying arcsinh()
+ expected_output = [np.arcsinh(-np.pi/2), np.arcsinh(-np.pi/4), 0, np.arcsinh(np.pi/4), np.arcsinh(np.pi/2)]
+ assert_correctness_of_trigonometric_ops(y, expected_output)
+
+ def check_arccosh():
+ x = create_input_for_trigonometric_ops([1, np.pi/2, 3*np.pi/4, np.pi])
+ y = nd.arccosh(x)
+ # expected ouput for indices=(0, 1, -3, -2, -1) after applying arccosh()
+ expected_output = [0, np.arccosh(np.pi/2), np.arccosh(3*np.pi/4), np.arccosh(np.pi)]
+ assert_correctness_of_trigonometric_ops(y, expected_output)
+
+ def check_arctanh():
+ x = create_input_for_trigonometric_ops([-1/4, -1/2, 0, 1/4, 1/2])
+ y = nd.arctanh(x)
+ # expected ouput for indices=(0, 1, -3, -2, -1) after applying arctanh()
+ expected_output = [np.arctanh(-1/4), np.arctanh(-1/2), 0, np.arctanh(1/4), np.arctanh(1/2)]
+ assert_correctness_of_trigonometric_ops(y, expected_output)
+
+ def check_sinh():
+ x = create_input_for_trigonometric_ops([-np.pi/2, -np.pi/4, 0, np.pi/4, np.pi/2])
+ y = nd.sinh(x)
+ # expected ouput for indices=(0, 1, -3, -2, -1) after applying sinh()
+ expected_output = [np.sinh(-np.pi/2), np.sinh(-np.pi/4), 0, np.sinh(np.pi/4), np.sinh(np.pi/2)]
+ assert_correctness_of_trigonometric_ops(y, expected_output)
+
+ def check_cosh():
+ x = create_input_for_trigonometric_ops([0, 1, np.pi/2, 3*np.pi/4, np.pi])
+ y = nd.cosh(x)
+ # expected ouput for indices=(0, 1, -3, -2, -1) after applying cosh()
+ expected_output = [1, np.cosh(1), np.cosh(np.pi/2), np.cosh(3*np.pi/4), np.cosh(np.pi)]
+ assert_correctness_of_trigonometric_ops(y, expected_output)
+
+ def check_tanh():
+ x = create_input_for_trigonometric_ops([-1/4, -1/2, 0, 1/4, 1/2])
+ y = nd.tanh(x)
+ # expected ouput for indices=(0, 1, -3, -2, -1) after applying tanh()
+ expected_output = [np.tanh(-1/4), np.tanh(-1/2), 0, np.tanh(1/4), np.tanh(1/2)]
+ assert_correctness_of_trigonometric_ops(y, expected_output)
Review comment:
why are trigonometric ops being compared with the `assert_correctness_of_trigonometric_ops` function. why not use `assert_almost_equal` from the test `utils.py` file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services