You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/23 00:38:56 UTC
Review Request 42673: Silenced two more GMock warnings about shutdown
expectations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42673/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Repository: mesos
Description
-------
In these tests:
* MasterTest.OrphanTasks
* StatusUpdateManagerTest.LatestTaskState
Diffs
-----
src/tests/master_tests.cpp cd426fda633c2d665b9533271610863062b1ed4e
src/tests/status_update_manager_tests.cpp 24302d8627e635f3825a31d5383de2448ad9d557
Diff: https://reviews.apache.org/r/42673/diff/
Testing
-------
Verified that GMock warnings are observed w/o this review; after applying the review and running `--gtest_repeat=100`, no warnings were observed.
Thanks,
Neil Conway
Re: Review Request 42673: Silenced two more GMock warnings about
shutdown expectations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42673/#review115976
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42673]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 22, 2016, 11:38 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42673/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 11:38 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In these tests:
> * MasterTest.OrphanTasks
> * StatusUpdateManagerTest.LatestTaskState
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp cd426fda633c2d665b9533271610863062b1ed4e
> src/tests/status_update_manager_tests.cpp 24302d8627e635f3825a31d5383de2448ad9d557
>
> Diff: https://reviews.apache.org/r/42673/diff/
>
>
> Testing
> -------
>
> Verified that GMock warnings are observed w/o this review; after applying the review and running `--gtest_repeat=100`, no warnings were observed.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42673: Silenced two more GMock warnings about
shutdown expectations.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42673/#review116737
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Jan. 22, 2016, 11:38 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42673/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 11:38 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In these tests:
> * MasterTest.OrphanTasks
> * StatusUpdateManagerTest.LatestTaskState
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp cd426fda633c2d665b9533271610863062b1ed4e
> src/tests/status_update_manager_tests.cpp 24302d8627e635f3825a31d5383de2448ad9d557
>
> Diff: https://reviews.apache.org/r/42673/diff/
>
>
> Testing
> -------
>
> Verified that GMock warnings are observed w/o this review; after applying the review and running `--gtest_repeat=100`, no warnings were observed.
>
>
> Thanks,
>
> Neil Conway
>
>