[jira] [Commented] (TAJO-329) Implement physical operator to store in column-partitioned table.

["Hyunsik Choi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842844#comment-13842844 ] 

Hyunsik Choi commented on TAJO-329:
-----------------------------------

In overall, the patch looks good for me. I leave a couple of comments:

* ScanNode contains some code about partitions. Even though it may be necessary later, this is not a part of this issue.
* Could you please add unit tests for two or more partition columns to TestInsertQuery.java?
  ** These unit tests are necessary.
* ColumnPartitionedTableStoreExec::next() contains unused variable *value*.
* It would be better to use datum.asChars() instead of datum.toString(). 
  ** toString is not intended to output a pure value string.
* I would like to recommend using StringBuilder rather than StringBuffer in those cases. StringBuffer is a thread-safe data structure, and it may be more costly than StringBuilder.

> Implement physical operator to store in column-partitioned table.
> -----------------------------------------------------------------
>
>                 Key: TAJO-329
>                 URL: https://issues.apache.org/jira/browse/TAJO-329
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: physical operator
>    Affects Versions: 0.8-incubating
>            Reporter: JaeHwa Jung
>            Assignee: JaeHwa Jung
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-329.patch
>
>
> We have to implement physical operators for partitioned table. First of all, I'm going to implement a physical operator to store in column-partitioned table. And I'll make another jira issue to implement a operator to load. After I fix all issue, I'm going to update HiveConverter and HCatalogStore.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)